[TSVB] hide only duplicated consecutive ticks #70981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
bug
spalger
approved these changes
Jul 7, 2020
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
Operations: ui-shared-deps upgrade LGTM
1 task
Member
Author
|
@elasticmachine merge upstream |
flash1293
approved these changes
Jul 8, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested in FF and works as expected, LGTM 👍 Thanks for fixing
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Jul 8, 2020
Co-authored-by: Elastic Machine <[email protected]>
markov00
added a commit
that referenced
this pull request
Jul 8, 2020
Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 9, 2020
* master: [RUM Dashboard] New rum services api to replace usage of get services API (elastic#70746) fix: remove only consecutive ticks in TSVB (elastic#70981) [Functional test] Increase the timeout on opening a saved visualization (elastic#70952) [ML] Transforms/DFA: Refactor list action buttons so modals won't unmount after button click. (elastic#70555) [Functional test] Add retry for dashboard save (elastic#70950)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the TSVB issue with missing ticks when trying to remove duplicate ticks.
The previous implement just de-duplicate ticks checking and returning only unique ticks, but doesn't cover all the cases.
This patch elastic/elastic-charts#742 resolves the problem inside elastic-charts and fixes that on TSVB
From:
To:
fix #70956
For maintainers