[Ingest Manager] change user facing text "Data streams" to "datasets" #70840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
neptunian
added
7.9.0
release_note:skip
neptunian
changed the title
nchaulet
approved these changes
Jul 6, 2020
jen-huang
approved these changes
Jul 6, 2020
Contributor
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Jul 6, 2020
neptunian
added a commit
that referenced
this pull request
Jul 6, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #70024
This PR only changes the user facing text from Data Streams to Datasets as well as the route as I think from a developer perspective we think of them as Data streams. There is also already a Dataset model that EPM uses to handle datasets from packages.
If there is a feeling we should change all the code from "data streams" to "dataset" because it would be confusing to the developer, we could discuss renaming the epm dataset model to something else.
To test:
In the Ingest Manager app, navigate to the Datasets app. There should be no mention of "Data streams" and the route should be
datasetand notdata-stream