[backport] PR #6773 to 4.5 #7079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- **Commit 1:** [state] add configurable warning level based on url length * Original sha: 55db90d * Authored by spalger <[email protected]> on 2016-04-04T21:57:45Z **Commit 2:** [state] add a hard length limit that will start throwing errors * Original sha: 64699aa * Authored by spalger <[email protected]> on 2016-04-04T22:14:06Z **Commit 3:** Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength * Original sha: 4c70d69 * Authored by spalger <[email protected]> on 2016-04-06T07:05:47Z **Commit 4:** [dashboard] cleanup quietly to prevent error * Original sha: 1dace5c * Authored by spalger <[email protected]> on 2016-04-06T08:50:55Z **Commit 5:** [errorview] add url overflow display * Original sha: 8b4ebf5 * Authored by spalger <[email protected]> on 2016-04-06T08:51:47Z **Commit 6:** [errorview] persist the overflow url so that refresh works * Original sha: e308db9 * Authored by spalger <[email protected]> on 2016-04-06T09:05:13Z **Commit 7:** Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength * Original sha: 121e4f2 * Authored by spalger <[email protected]> on 2016-04-15T18:49:12Z **Commit 8:** [config] remove url limit config, it should adapt automatically * Original sha: 281b38b * Authored by spalger <[email protected]> on 2016-04-15T23:38:05Z **Commit 9:** [chrome] rework url overflow detection The previous version of this pr relied on the State service to catch times when the URL would grow out of control. While overflows will commonly occur in the State service, this didn't handle urls that were navigated to using a link. They worked because the state service would eventually be called, but the failure was unexpected and required interaction to trigger. This new approach does the checking at a higher level, in the chrome. We also removed the `url:limit` configuration value in favor of browser detection (I was not able to find or come up with a way to quietly and quickly feature detect this). The new limits are 2000 characters for IE and 25000 for all other browsers. * Original sha: 116521c * Authored by spalger <[email protected]> on 2016-04-15T23:40:18Z **Commit 10:** Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength * Original sha: aa030d7 * Authored by spalger <[email protected]> on 2016-04-26T16:51:22Z **Commit 11:** [ui/config] remove unused default * Original sha: b333c51 * Authored by spalger <[email protected]> on 2016-04-26T16:52:29Z **Commit 12:** Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength * Original sha: 133d7e5 * Authored by spalger <[email protected]> on 2016-04-27T23:17:44Z **Commit 13:** [urlOverflow] assign magic numbers to variables * Original sha: 8b97881 * Authored by spalger <[email protected]> on 2016-04-27T23:24:17Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #6773
Commit 1:
[state] add configurable warning level based on url length
Commit 2:
[state] add a hard length limit that will start throwing errors
Commit 3:
Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength
Commit 4:
[dashboard] cleanup quietly to prevent error
Commit 5:
[errorview] add url overflow display
Commit 6:
[errorview] persist the overflow url so that refresh works
Commit 7:
Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength
Commit 8:
[config] remove url limit config, it should adapt automatically
Commit 9:
[chrome] rework url overflow detection
The previous version of this pr relied on the State service to catch times when the URL would grow out of control. While overflows will commonly occur in the State service, this didn't handle urls that were navigated to using a link. They worked because the state service would eventually be called, but the failure was unexpected and required interaction to trigger.
This new approach does the checking at a higher level, in the chrome.
We also removed the
url:limitconfiguration value in favor of browser detection (I was not able to find or come up with a way to quietly and quickly feature detect this). The new limits are 2000 characters for IE and 25000 for all other browsers.Commit 10:
Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength
Commit 11:
[ui/config] remove unused default
Commit 12:
Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength
Commit 13:
[urlOverflow] assign magic numbers to variables