[Security Solution][Endpoint] Update to new manifest format (without compression)#70752
Merged
madirey merged 7 commits intoelastic:masterfrom Jul 4, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
Contributor
|
Pinging @elastic/endpoint-response (Team:Endpoint Response) |
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
2a266b3 to
dc52c77
Compare
dc52c77 to
ceca5fa
Compare
brian-mckinney
approved these changes
Jul 4, 2020
brian-mckinney
left a comment
There was a problem hiding this comment.
Looks good to me, the updated format matches what I'm tracking in the endpoint.
peluja1012
reviewed
Jul 4, 2020
| ); | ||
| export type TranslatedEntryMatchAny = t.TypeOf<typeof translatedEntryMatchAny>; | ||
|
|
||
| export const translatedEntryMatchAnyMatcher = translatedEntryMatchAny.type.props.type; |
Contributor
There was a problem hiding this comment.
Another way to do this would be to define a type like MatchAny:
t.keyof({
exact_cased_any: null,
exact_caseless_any: null,
})
Then use this new type in both translatedEntryMatchAny and translatedEntryMatchAnyMatcher
peluja1012
approved these changes
Jul 4, 2020
Contributor
peluja1012
left a comment
There was a problem hiding this comment.
Looks good. Just left a suggestion related to types.
Contributor
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-optimizer/src/integration_tests.builds expected bundles, saves bundle counts to metadataStandard OutStack TraceBuild metrics
History
To update your PR or re-run it, just comment with: |
21 tasks
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 6, 2020
* master: [APM-UI] e2e speed up build (elastic#70704) skip flaky suite (elastic#70764) skip flaky suite (elastic#70762) [Security Solution][Endpoint] Update to new manifest format (without compression) (elastic#70752) [functional tests] test url field formatter on dashboard and discover (elastic#70736) logout from transform_poweruser user in after method of transform tests (elastic#70644) [SECURITY] Bug fix for topN on draggables (elastic#70450) [Logs UI] Reorganise log rate anomaly table (elastic#69516) Update dependency @elastic/charts to v19.7.0 (elastic#69791) Add googlecloud metricbeat module to Kibana Home (elastic#70652) [Logs UI] Logs overview queries for the observability dashboard (elastic#70413) [Lens] Fitting functions (elastic#69820)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 6, 2020
* master: [APM-UI] e2e speed up build (elastic#70704) skip flaky suite (elastic#70764) skip flaky suite (elastic#70762) [Security Solution][Endpoint] Update to new manifest format (without compression) (elastic#70752) [functional tests] test url field formatter on dashboard and discover (elastic#70736) logout from transform_poweruser user in after method of transform tests (elastic#70644) [SECURITY] Bug fix for topN on draggables (elastic#70450) [Logs UI] Reorganise log rate anomaly table (elastic#69516) Update dependency @elastic/charts to v19.7.0 (elastic#69791) Add googlecloud metricbeat module to Kibana Home (elastic#70652) [Logs UI] Logs overview queries for the observability dashboard (elastic#70413)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 6, 2020
* actions/feature: fixed type errors [APM-UI] e2e speed up build (elastic#70704) skip flaky suite (elastic#70764) skip flaky suite (elastic#70762) [Security Solution][Endpoint] Update to new manifest format (without compression) (elastic#70752) [functional tests] test url field formatter on dashboard and discover (elastic#70736) logout from transform_poweruser user in after method of transform tests (elastic#70644) [SECURITY] Bug fix for topN on draggables (elastic#70450) [Logs UI] Reorganise log rate anomaly table (elastic#69516) Update dependency @elastic/charts to v19.7.0 (elastic#69791) Add googlecloud metricbeat module to Kibana Home (elastic#70652) [Logs UI] Logs overview queries for the observability dashboard (elastic#70413)
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the manifest and artifact delivery to conform to the new format which supports compression and encryption.
Additionally, some fixes are provided to address feedback from #67707.
Additional fixes and the actual compression of artifacts will be added in a follow-up PR.
Checklist
N/A
To be addressed in follow-up PR
async/awaittothen@ts-ignoretype errorsif(someType.is(...))toas)For maintainers