[SIEM][Detection Engine] Speeds up value list imports by enabling streaming of files.#70685
Conversation
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
I got a walkthrough of the streaming logic from @FrankHassanabad, and the code looks good!
I tested this against #67068, and it decreased import time of a 1.2kB file from 52s to 444ms. So yeah, this is an improvement to say the least 😉 .
|
|
||
| public _read(): void { | ||
| // No operation but this is required to be implemented | ||
| public _read(): void {} |
There was a problem hiding this comment.
I was gonna say we should leave the comment, but the typescript error generated if one removes this method should be straightforward 👍
yctercero
left a comment
There was a problem hiding this comment.
LGTM. Saw Ryland pulled down to test, so was just looking at the code. This is really awesome!
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/siem (Team:SIEM) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
Checklist