[Lens] Improve no data popover styles#70594
Merged
flash1293 merged 7 commits intoelastic:masterfrom Jul 6, 2020
Merged
Conversation
flash1293
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
cchaos
reviewed
Jul 2, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Woo, thanks!! Maybe we should also add in a title="Empty dataset" or whatever we should call the currently selected timerange of data.
Contributor
|
LGTM, Just missing a period at the end of the last sentence.
|
Contributor
|
LGTM. Just missing a period at the end of the sentence.
|
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jul 6, 2020
flash1293
added a commit
that referenced
this pull request
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super small follow up (#69147 (comment))
Improves styles of the "no data" popover dismiss button
Before
After
