[Metrics UI] Register function for Observability homepage#70529
Merged
simianhacker merged 3 commits intoelastic:masterfrom Jul 2, 2020
Merged
Conversation
simianhacker
added
Feature:Metrics UI
simianhacker
force-pushed
the
issue-68532-obs-homepage-fn-for-metrics
branch
from
54dd0c0 to
900f48c
Compare
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
2 tasks
jasonrhodes
approved these changes
Jul 2, 2020
Member
jasonrhodes
left a comment
jasonrhodes
left a comment
There was a problem hiding this comment.
Tested hasData and fetchData both, they work as expected. Tests look good too, nice addition.
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
simianhacker
added a commit
that referenced
this pull request
Jul 2, 2020
…70647) * [Metrics UI] Register function for Observability homepage * Updating types; removing relative path from appLink Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #68532 by creating and registering a functions for the Observability Homepage. The one notable change to the response for
fetchDatais that I removed thediskstats since we don't have a reliable way to summarize that data.Checklist
Delete any items that are not applicable to this PR.