Skip to content

Revert "[eslint][ts] Enable prefer-ts-expect-error"#70474

Merged
tylersmalley merged 1 commit intomasterfrom
revert-70022-eslint-prefer-expect-error
Jul 1, 2020
Merged

Revert "[eslint][ts] Enable prefer-ts-expect-error"#70474
tylersmalley merged 1 commit intomasterfrom
revert-70022-eslint-prefer-expect-error

Conversation

@tylersmalley
Copy link
Member

Reverts #70022

@clintandrewhall, I am going to revert this for now. We will need to do some cleanup of these warnings first, and address #70451.

@tylersmalley tylersmalley requested a review from a team as a code owner July 1, 2020 16:14
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jul 1, 2020
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we don't really have "warnings" right now, and I don't think we should. We should make up our minds and auto-fix the whole repo if we want to go this route.

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/basic/tests/find_statuses·ts.detection engine api security and spaces enabled find_statuses "after each" hook for "should return a single rule status when a single rule is loaded from a find status with defaults added"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 4 times on tracked branches: https://github.com/elastic/kibana/issues/69632

[00:00:00]       │
[00:00:00]         └-: detection engine api security and spaces enabled
[00:00:00]           └-> "before all" hook
[00:01:56]           └-: find_statuses
[00:01:56]             └-> "before all" hook
[00:01:56]             └-> should return an empty find statuses body correctly if no statuses are loaded
[00:01:56]               └-> "before each" hook: global before each
[00:01:56]               └-> "before each" hook
[00:01:56]                 │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] adding index lifecycle policy [.siem-signals-default]
[00:01:56]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:01:56]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1], mappings [_doc]
[00:01:56]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:01:56]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [.siem-signals-default]
[00:01:56]               └- ✓ pass  (13ms) "detection engine api security and spaces enabled find_statuses should return an empty find statuses body correctly if no statuses are loaded"
[00:01:56]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [.siem-signals-default]
[00:01:56]             └-> "after each" hook
[00:01:56]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] [.siem-signals-default-000001/X8ejR2plRM-ABBFrrLak9w] deleting index
[00:01:56]               │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] removing template [.siem-signals-default]
[00:01:56]             └-> should return a single rule status when a single rule is loaded from a find status with defaults added
[00:01:56]               └-> "before each" hook: global before each
[00:01:56]               └-> "before each" hook
[00:01:56]                 │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] adding index lifecycle policy [.siem-signals-default]
[00:01:56]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:01:56]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1], mappings [_doc]
[00:01:56]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:01:56]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [.siem-signals-default]
[00:01:56]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [.siem-signals-default]
[00:01:59]               └- ✓ pass  (2.5s) "detection engine api security and spaces enabled find_statuses should return a single rule status when a single rule is loaded from a find status with defaults added"
[00:01:59]             └-> "after each" hook
[00:01:59]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] [.siem-signals-default-000001/s9L2xbaMSmSZUubtAUPYvg] deleting index
[00:01:59]               │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1593620130445970632] removing template [.siem-signals-default]
[00:01:59]               └- ✖ fail: "detection engine api security and spaces enabled find_statuses "after each" hook for "should return a single rule status when a single rule is loaded from a find status with defaults added""
[00:01:59]               │

Stack Trace

{ ResponseError: Response Error
    at IncomingMessage.response.on (/dev/shm/workspace/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:287:25)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
  name: 'ResponseError',
  meta:
   { body:
      { took: 4,
        timed_out: false,
        total: 1,
        deleted: 0,
        batches: 1,
        version_conflicts: 1,
        noops: 0,
        retries: [Object],
        throttled_millis: 0,
        requests_per_second: -1,
        throttled_until_millis: 0,
        failures: [Array] },
     statusCode: 409,
     headers:
      { 'content-type': 'application/json; charset=UTF-8',
        'content-length': '649' },
     warnings: null,
     meta:
      { context: null,
        request: [Object],
        name: 'elasticsearch-js',
        connection: [Object],
        attempts: 0,
        aborted: false } } }

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet mentioned this pull request Jul 1, 2020
2 tasks
@tylersmalley tylersmalley merged commit 97924a6 into master Jul 1, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 3, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 70474 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 70474 or prevent reminders by adding the backport:skip label.

@clintandrewhall clintandrewhall added backport:skip This PR does not require backporting reverted and removed backport missing Added to PRs automatically when the are determined to be missing a backport. reverted labels Jul 7, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 70474 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 9, 2020
@tylersmalley tylersmalley deleted the revert-70022-eslint-prefer-expect-error branch May 10, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants