Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
4e180aa
refactor: 💡 rename folder to "explore_data"
streamich Jun 18, 2020
428bbab
style: 💄 check for "share" plugin in more semantic way
streamich Jun 18, 2020
11c6b64
refactor: 💡 move KibanaURL to a separate file
streamich Jun 18, 2020
795bfbb
feat: 🎸 add "Explore underlying data" in-chart action
streamich Jun 18, 2020
64ce4c4
fix: 🐛 fix imports after refactor
streamich Jun 18, 2020
55992da
feat: 🎸 add start.filtersFromContext to embeddable plugin
streamich Jun 18, 2020
a730c55
feat: 🎸 add type checkers to data plugin
streamich Jun 18, 2020
00a7aa3
feat: 🎸 better handle empty filters in Discover URL generator
streamich Jun 18, 2020
088feb1
feat: 🎸 implement .getUrl() method of explore data in-chart act
streamich Jun 18, 2020
302702f
feat: 🎸 add embeddable.filtersAndTimeRangeFromContext()
streamich Jun 18, 2020
5217996
feat: 🎸 improve getUrl() method of explore data action
streamich Jun 18, 2020
ec890c6
test: 💍 update test mock
streamich Jun 18, 2020
45f4cc4
Merge remote-tracking branch 'upstream/master' into chart-underlying-…
streamich Jun 23, 2020
9b5739a
fix possible stale hashHistory.location in discover
Dosant Jun 24, 2020
d2747a7
chore: 🤖 merge master
streamich Jun 25, 2020
eb61452
style: 💄 ensureHashHistoryLocation -> syncHistoryLocations
streamich Jun 25, 2020
406e02d
docs: ✏️ update autogenerated docs
streamich Jun 25, 2020
599382b
test: 💍 add in-chart "Explore underlying data" unit tests
streamich Jun 25, 2020
4ceefdd
test: 💍 add in-chart "Explore underlying data" functional tests
streamich Jun 25, 2020
0e29de3
test: 💍 clean-up custom time range after panel action tests
streamich Jun 25, 2020
424414f
chore: 🤖 fix embeddable plugin mocks
streamich Jun 25, 2020
dcef452
chore: 🤖 fix another mock
streamich Jun 25, 2020
905f0bc
test: 💍 add support for new action to pie chart service
streamich Jun 25, 2020
b567eb2
Merge remote-tracking branch 'upstream/master' into chart-underlying-…
streamich Jun 26, 2020
e4945cd
feat: 🎸 add kibana.yml to disable in-chart "explore data" actio
streamich Jun 26, 2020
c8485ed
Merge remote-tracking branch 'upstream/master' into explore-data-flag
streamich Jun 26, 2020
f4eb103
Merge branch 'master' into explore-data-flag
elasticmachine Jun 29, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions x-pack/plugins/discover_enhanced/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
"id": "discoverEnhanced",
"version": "8.0.0",
"kibanaVersion": "kibana",
"server": false,
"server": true,
"ui": true,
"requiredPlugins": ["uiActions", "embeddable", "discover"],
"optionalPlugins": ["share"]
"optionalPlugins": ["share"],
"configPath": ["xpack", "discoverEnhanced"]
}
14 changes: 10 additions & 4 deletions x-pack/plugins/discover_enhanced/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ export interface DiscoverEnhancedStartDependencies {
export class DiscoverEnhancedPlugin
implements
Plugin<void, void, DiscoverEnhancedSetupDependencies, DiscoverEnhancedStartDependencies> {
constructor(public readonly initializerContext: PluginInitializerContext) {}
public readonly config: { actions: { exploreDataInChart: { enabled: boolean } } };

constructor(protected readonly context: PluginInitializerContext) {
this.config = context.config.get();
}

setup(
core: CoreSetup<DiscoverEnhancedStartDependencies>,
Expand All @@ -68,9 +72,11 @@ export class DiscoverEnhancedPlugin
const exploreDataAction = new ExploreDataContextMenuAction(params);
uiActions.addTriggerAction(CONTEXT_MENU_TRIGGER, exploreDataAction);

const exploreDataChartAction = new ExploreDataChartAction(params);
uiActions.addTriggerAction(SELECT_RANGE_TRIGGER, exploreDataChartAction);
uiActions.addTriggerAction(VALUE_CLICK_TRIGGER, exploreDataChartAction);
if (this.config.actions.exploreDataInChart.enabled) {
const exploreDataChartAction = new ExploreDataChartAction(params);
uiActions.addTriggerAction(SELECT_RANGE_TRIGGER, exploreDataChartAction);
uiActions.addTriggerAction(VALUE_CLICK_TRIGGER, exploreDataChartAction);
}
}
}

Expand Down
25 changes: 25 additions & 0 deletions x-pack/plugins/discover_enhanced/server/config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/

import { schema, TypeOf } from '@kbn/config-schema';
import { PluginConfigDescriptor } from '../../../../src/core/server';

export const configSchema = schema.object({
actions: schema.object({
exploreDataInChart: schema.object({
enabled: schema.boolean({ defaultValue: true }),
}),
}),
});

export type ConfigSchema = TypeOf<typeof configSchema>;

export const config: PluginConfigDescriptor<ConfigSchema> = {
schema: configSchema,
exposeToBrowser: {
actions: true,
},
};
12 changes: 12 additions & 0 deletions x-pack/plugins/discover_enhanced/server/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/

export { config } from './config';

export const plugin = () => ({
setup() {},
start() {},
});