[Discover] set minBarHeight for high cardinality by nickofthyme · Pull Request #69875 · elastic/kibana

nickofthyme · 2020-06-25T03:02:07Z

Summary

Set minBarHeight on discover histogram to always show min bar height of 1px for non-zero values in high cardinality datasets.

kertal

Code LGTM, tested locally, Chrome by adding a lonely kibana_sample_data_ecommerce record from a long time ago. Before this fix it was ignored:

now its displayed:

A small but nice change

nickofthyme · 2020-06-25T15:04:46Z

@kertal That is a great dataset for this 🤣

Do you think 1px is enough or should I make it 2 or 3?

kertal · 2020-06-25T15:09:24Z

FYI @andreadelrio / @snide (Think 1 px is enough since we will reduce height of the histogram, WDYT?)

andreadelrio · 2020-06-25T17:04:52Z

FYI @andreadelrio / @snide (Think 1 px is enough since we will reduce height of the histogram, WDYT?)

I almost missed that bar when I ran this locally. I would consider 2px.

nickofthyme · 2020-06-25T17:47:34Z

Updated to 2px 🥈

kibanamachine · 2020-06-25T19:35:04Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 3e0678f
Flaky suites:
- xpack-kibana-ciGroup10

Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/layer_errors·js.maps app layer errors ESJoinSource with missing index pattern id should diplay error message in layer panel

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 3 times on tracked branches: https://github.com/elastic/kibana/issues/69617

[00:00:00]       │
[00:00:00]         └-: maps app
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:00]             │ info [logstash_functional] Loading "mappings.json"
[00:00:00]             │ info [logstash_functional] Loading "data.json.gz"
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:00]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.22][0]]"
[00:00:00]             │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:00:00]             │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:00]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.20][0]]"
[00:00:00]             │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:00:00]             │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:00]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.21][0]]"
[00:00:00]             │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:00:00]             │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:01]             │ proc [kibana]   log   [18:21:15.417] [warning][plugins][reporting] Enabling the Chromium sandbox provides an additional layer of protection.
[00:00:10]             │ info progress: 9325
[00:00:13]             │ info [logstash_functional] Indexed 4634 docs into "logstash-2015.09.22"
[00:00:13]             │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:00:13]             │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:00:13]             │ info [maps/data] Loading "mappings.json"
[00:00:13]             │ info [maps/data] Loading "data.json"
[00:00:13]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [geo_shapes] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:13]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[geo_shapes][0]]])." previous.health="YELLOW" reason="shards started [[geo_shapes][0]]"
[00:00:14]             │ info [maps/data] Created index "geo_shapes"
[00:00:14]             │ debg [maps/data] "geo_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:14]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [meta_for_geo_shapes] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:14]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[meta_for_geo_shapes][0]]])." previous.health="YELLOW" reason="shards started [[meta_for_geo_shapes][0]]"
[00:00:14]             │ info [maps/data] Created index "meta_for_geo_shapes"
[00:00:14]             │ debg [maps/data] "meta_for_geo_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:14]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [antimeridian_points] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:14]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[antimeridian_points][0]]])." previous.health="YELLOW" reason="shards started [[antimeridian_points][0]]"
[00:00:14]             │ info [maps/data] Created index "antimeridian_points"
[00:00:14]             │ debg [maps/data] "antimeridian_points" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:14]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [antimeridian_shapes] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:14]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[antimeridian_shapes][0]]])." previous.health="YELLOW" reason="shards started [[antimeridian_shapes][0]]"
[00:00:14]             │ info [maps/data] Created index "antimeridian_shapes"
[00:00:14]             │ debg [maps/data] "antimeridian_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:14]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [flights] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:14]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[flights][0]]])." previous.health="YELLOW" reason="shards started [[flights][0]]"
[00:00:14]             │ info [maps/data] Created index "flights"
[00:00:14]             │ debg [maps/data] "flights" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:14]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [connections] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:14]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[connections][0]]])." previous.health="YELLOW" reason="shards started [[connections][0]]"
[00:00:14]             │ info [maps/data] Created index "connections"
[00:00:14]             │ debg [maps/data] "connections" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:14]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [meta_for_geo_shapes/FncOdQzbT-e2C3YaaUnFKg] update_mapping [_doc]
[00:00:14]             │ info [maps/data] Indexed 4 docs into "geo_shapes"
[00:00:14]             │ info [maps/data] Indexed 6 docs into "meta_for_geo_shapes"
[00:00:14]             │ info [maps/data] Indexed 3 docs into "antimeridian_points"
[00:00:14]             │ info [maps/data] Indexed 3 docs into "antimeridian_shapes"
[00:00:14]             │ info [maps/data] Indexed 3 docs into "flights"
[00:00:14]             │ info [maps/data] Indexed 4 docs into "connections"
[00:00:14]             │ info [maps/kibana] Loading "mappings.json"
[00:00:14]             │ info [maps/kibana] Loading "data.json"
[00:00:14]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana_1/ygMGxXIiQ9yqJMuIJVLczA] deleting index
[00:00:14]             │ info [maps/kibana] Deleted existing index [".kibana_1"]
[00:00:14]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:14]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]])." previous.health="YELLOW" reason="shards started [[.kibana][0]]"
[00:00:14]             │ info [maps/kibana] Created index ".kibana"
[00:00:14]             │ debg [maps/kibana] ".kibana" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:14]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana/65sY1b3hQnWGxr8F8ip4yA] update_mapping [_doc]
[00:00:15]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana/65sY1b3hQnWGxr8F8ip4yA] update_mapping [_doc]
[00:00:15]             │ info [maps/kibana] Indexed 29 docs into ".kibana"
[00:00:15]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana/65sY1b3hQnWGxr8F8ip4yA] update_mapping [_doc]
[00:00:15]             │ debg Migrating saved objects
[00:00:15]             │ proc [kibana]   log   [18:21:29.301] [info][savedobjects-service] Creating index .kibana_2.
[00:00:15]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:15]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] updating number_of_replicas to [0] for indices [.kibana_2]
[00:00:15]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_2][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_2][0]]"
[00:00:15]             │ proc [kibana]   log   [18:21:29.451] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:00:15]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:15]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] updating number_of_replicas to [0] for indices [.kibana_1]
[00:00:15]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_1][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_1][0]]"
[00:00:15]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.tasks] creating index, cause [auto(task api)], templates [], shards [1]/[1], mappings [_doc]
[00:00:15]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] updating number_of_replicas to [0] for indices [.tasks]
[00:00:16]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.tasks][0]]])." previous.health="YELLOW" reason="shards started [[.tasks][0]]"
[00:00:16]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] 1885 finished with response BulkByScrollResponse[took=176ms,timed_out=false,sliceId=null,updated=0,created=29,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:00:16]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana/65sY1b3hQnWGxr8F8ip4yA] deleting index
[00:00:16]             │ proc [kibana]   log   [18:21:30.187] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:00:16]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana_2/lliEUNAqSL-Pg1xsQyYBIQ] update_mapping [_doc]
[00:00:16]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana_2/lliEUNAqSL-Pg1xsQyYBIQ] update_mapping [_doc]
[00:00:16]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana_2/lliEUNAqSL-Pg1xsQyYBIQ] update_mapping [_doc]
[00:00:16]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana_2/lliEUNAqSL-Pg1xsQyYBIQ] update_mapping [_doc]
[00:00:16]             │ proc [kibana]   log   [18:21:30.549] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:00:16]             │ proc [kibana]   log   [18:21:30.623] [info][savedobjects-service] Finished in 1327ms.
[00:00:16]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:00:17]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana_2/lliEUNAqSL-Pg1xsQyYBIQ] update_mapping [_doc]
[00:00:17]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana_2/lliEUNAqSL-Pg1xsQyYBIQ] update_mapping [_doc]
[00:00:18]             │ debg replacing kibana config doc: {"defaultIndex":"logstash-*"}
[00:00:18]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1593107253642408433] [.kibana_2/lliEUNAqSL-Pg1xsQyYBIQ] update_mapping [_doc]
[00:00:19]           └-: 
[00:00:19]             └-> "before all" hook
[00:18:38]             └-: layer errors
[00:18:38]               └-> "before all" hook
[00:18:38]               └-> "before all" hook
[00:18:38]                 │ debg Load Saved Map layer with errors
[00:18:38]                 │ debg searchForMapWithName: layer with errors
[00:18:38]                 │ debg gotoMapListingPage
[00:18:38]                 │ debg onMapListingPage
[00:18:38]                 │ debg TestSubjects.exists(mapsListingPage)
[00:18:38]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mapsListingPage"]') with timeout=3500
[00:18:41]                 │ debg --- retry.tryForTime error: [data-test-subj="mapsListingPage"] is not displayed
[00:18:44]                 │ debg --- retry.tryForTime failed again with the same message...
[00:18:44]                 │ debg navigateToActualUrl http://localhost:61111/app/maps/
[00:18:45]                 │ debg browser[INFO] http://localhost:61111/app/maps/?_t=1593110398632 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:18:45]                 │
[00:18:45]                 │ debg browser[INFO] http://localhost:61111/bundles/app/core/bootstrap.js 43:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:18:45]                 │ debg currentUrl = http://localhost:61111/app/maps/
[00:18:45]                 │          appUrl = http://localhost:61111/app/maps/
[00:18:45]                 │ debg TestSubjects.find(kibanaChrome)
[00:18:45]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:18:47]                 │ debg onMapListingPage
[00:18:47]                 │ debg TestSubjects.exists(mapsListingPage)
[00:18:47]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mapsListingPage"]') with timeout=3500
[00:18:47]                 │ debg browser[INFO] http://localhost:61111/34023/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-06-25T18:40:00Z
[00:18:47]                 │        Adding connection to http://localhost:61111/elasticsearch
[00:18:47]                 │
[00:18:47]                 │      "
[00:18:47]                 │ debg TestSubjects.find(searchFilter)
[00:18:47]                 │ debg Find.findByCssSelector('[data-test-subj="searchFilter"]') with timeout=10000
[00:18:48]                 │ debg isGlobalLoadingIndicatorVisible
[00:18:48]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:18:48]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:18:49]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:18:49]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:18:49]                 │ debg TestSubjects.click(mapListingTitleLink-layer-with-errors)
[00:18:49]                 │ debg Find.clickByCssSelector('[data-test-subj="mapListingTitleLink-layer-with-errors"]') with timeout=10000
[00:18:49]                 │ debg Find.findByCssSelector('[data-test-subj="mapListingTitleLink-layer-with-errors"]') with timeout=10000
[00:18:49]                 │ debg isGlobalLoadingIndicatorVisible
[00:18:49]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:18:49]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:18:50]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:18:50]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:18:51]                 │ debg onMapListingPage
[00:18:51]                 │ debg TestSubjects.exists(mapsListingPage)
[00:18:51]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mapsListingPage"]') with timeout=3500
[00:18:53]                 │ debg --- retry.tryForTime error: [data-test-subj="mapsListingPage"] is not displayed
[00:18:57]                 │ debg --- retry.tryForTime failed again with the same message...
[00:18:57]                 │ debg Wait for layers to load
[00:18:57]                 │ debg TestSubjects.find(mapLayerTOC)
[00:18:57]                 │ debg Find.findByCssSelector('[data-test-subj="mapLayerTOC"]') with timeout=10000
[00:19:26]               └-: ESJoinSource with missing index pattern id
[00:19:26]                 └-> "before all" hook
[00:19:26]                 └-> should diplay error message in layer panel
[00:19:26]                   └-> "before each" hook: global before each
[00:19:26]                   │ debg Remove layer geo_shapes*
[00:19:26]                   │ debg Open layer panel, layer: geo_shapes*
[00:19:26]                   │ debg TestSubjects.exists(layerTocActionsPanelgeo_shapes*)
[00:19:26]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="layerTocActionsPanelgeo_shapes*"]') with timeout=2500
[00:19:29]                   │ debg --- retry.tryForTime error: [data-test-subj="layerTocActionsPanelgeo_shapes*"] is not displayed
[00:19:30]                   │ debg TestSubjects.click(layerTocActionsPanelToggleButtongeo_shapes*)
[00:19:30]                   │ debg Find.clickByCssSelector('[data-test-subj="layerTocActionsPanelToggleButtongeo_shapes*"]') with timeout=10000
[00:19:30]                   │ debg Find.findByCssSelector('[data-test-subj="layerTocActionsPanelToggleButtongeo_shapes*"]') with timeout=10000
[00:19:30]                   │ debg TestSubjects.click(editLayerButton)
[00:19:30]                   │ debg Find.clickByCssSelector('[data-test-subj="editLayerButton"]') with timeout=10000
[00:19:30]                   │ debg Find.findByCssSelector('[data-test-subj="editLayerButton"]') with timeout=10000
[00:19:30]                   │ debg TestSubjects.getVisibleText(layerErrorMessage)
[00:19:30]                   │ debg TestSubjects.find(layerErrorMessage)
[00:19:30]                   │ debg Find.findByCssSelector('[data-test-subj="layerErrorMessage"]') with timeout=10000
[00:19:40]                   │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/maps app  layer errors ESJoinSource with missing index pattern id should diplay error message in layer panel.png"
[00:19:41]                   │ info Current URL is: http://localhost:61111/app/maps/map/745c98b0-23e1-11e9-a048-6fef5a3e0d1e#?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-7d,to:now))&_a=(filters:!(),query:(language:kuery,query:%27%27))
[00:19:41]                   │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/maps app  layer errors ESJoinSource with missing index pattern id should diplay error message in layer panel.html
[00:19:41]                   └- ✖ fail: "maps app  layer errors ESJoinSource with missing index pattern id should diplay error message in layer panel"
[00:19:41]                   │

Stack Trace

{ TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="layerErrorMessage"])
Wait timed out after 10100ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at process._tickCallback (internal/process/next_tick.js:68:7) name: 'TimeoutError', remoteStacktrace: '' }

Build metrics

✅ unchanged

History

💚 Build #56169 succeeded f2a3a29

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…t-pipelines/editor-error-messages * ingest-pipelines/editor-dropzone-refinement: (122 commits) Fixes for monaco XJSON grammar parser and update form copy Added cancel move button Refactor SCSS values to variables use classNames as it is intended to be used Remove box shadow on all nested tree items Rename variables and prefix booleans with "is" Fixes bug on color picker defaults on TSVB (elastic#69889) [DOCS] Fixes wording in Upload a CSV section (elastic#69969) [Discover] Validate timerange before submitting query to ES (elastic#69363) [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths (elastic#69723) [Maps] Fix icon palettes are not working (elastic#69937) [Ingest Manager] Fix typo in constant name (elastic#69919) [test] skip status.allowAnonymous tests on cloud (elastic#69017) Fix backport (elastic#70003) [Reporting] ReportingStore module (elastic#69426) Add reporting assets to the eslint ignore file (elastic#69968) [Discover] set minBarHeight for high cardinality data (elastic#69875) Add featureUsage API to licensing context provider (elastic#69838) Fix uncaught typecheck merge conflict (elastic#70001) Use TS to discourage SO mappings with dynamic: false / dynamic: true (elastic#69927) ...

[discover] set minBarHeight for high cardinality

f2a3a29

nickofthyme added Feature:Discover Discover Application enhancement New value added to drive a business result v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 25, 2020

nickofthyme requested review from a team, AlonaNadler and markov00 June 25, 2020 03:02

nickofthyme linked an issue Jun 25, 2020 that may be closed by this pull request

Discover: Provide a green line for histogram periods with "too few" (relative to other periods) documents to show a visible bar #68436

Closed

kertal approved these changes Jun 25, 2020

View reviewed changes

fix: update value to 2px

3e0678f

nickofthyme changed the title ~~[discover] set minBarHeight for high cardinality~~ [Discover] set minBarHeight for high cardinality Jun 25, 2020

nickofthyme merged commit ae51bf0 into elastic:master Jun 25, 2020

nickofthyme deleted the discover-min-height branch June 25, 2020 21:31

nickofthyme mentioned this pull request Jun 25, 2020

[7.x] [Discover] set minBarHeight for high cardinality data (#69875) #70012

Merged

nickofthyme added a commit that referenced this pull request Jun 25, 2020

[Discover] set minBarHeight for high cardinality data (#69875) (#70012)

c317540

nickofthyme mentioned this pull request Oct 19, 2020

When the difference between y-axis values are too high the bar chart isn't shown. elastic/elastic-charts#874

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] set minBarHeight for high cardinality#69875

[Discover] set minBarHeight for high cardinality#69875
nickofthyme merged 2 commits intoelastic:masterfrom
nickofthyme:discover-min-height

nickofthyme commented Jun 25, 2020 •

edited

Loading

Uh oh!

kertal left a comment

Uh oh!

nickofthyme commented Jun 25, 2020

Uh oh!

kertal commented Jun 25, 2020

Uh oh!

andreadelrio commented Jun 25, 2020

Uh oh!

nickofthyme commented Jun 25, 2020

Uh oh!

kibanamachine commented Jun 25, 2020

Standard Out

Stack Trace

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

nickofthyme commented Jun 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

nickofthyme commented Jun 25, 2020

Uh oh!

kertal commented Jun 25, 2020

Uh oh!

andreadelrio commented Jun 25, 2020

Uh oh!

nickofthyme commented Jun 25, 2020

Uh oh!

kibanamachine commented Jun 25, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Build metrics

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

nickofthyme commented Jun 25, 2020 •

edited

Loading