[7.8] remove scroll in drag & drop context (#69710)#69759
Merged
XavierM merged 1 commit intoelastic:7.8from Jun 24, 2020
Merged
[7.8] remove scroll in drag & drop context (#69710)#69759XavierM merged 1 commit intoelastic:7.8from
XavierM merged 1 commit intoelastic:7.8from
Conversation
andrew-goldstein
approved these changes
Jun 23, 2020
Contributor
andrew-goldstein
left a comment
andrew-goldstein
left a comment
There was a problem hiding this comment.
Re-tested this branch locally against a cloud 7.8 GA release:
- At 4k monitor resolutions
- At default laptop (MBP) resolutions
- In Timeline, Timeline-based views, and non-Timeline based views in various scroll states / expanded-event states
In the Network map (drag and drop from tooltips)- With both fields and column headers
- With the
Add to timeline investigationcontext menu (outside of Timeline, and within) - Dragging to an un-populated timeline (with Timeline open)
- Dragging to a populated timeline (with Timeline open)
- Dragging to an un-populated timeline (with Timeline closed)
- Dragging to a populated timeline (with Timeline closed)
- With Chrome
83.0.4103.106 - With Firefox
77.01 - With Safari
13.1.1
LGTM 🚀
Contributor
💚 Build SucceededBuild metricspage load asset sizebeta
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.8: