Skip to content

[Visualize] Add missing advanced settings and custom label for pipeline aggs#69688

Merged
sulemanof merged 6 commits intoelastic:masterfrom
sulemanof:fix/agg_advanced_settings
Jul 2, 2020
Merged

[Visualize] Add missing advanced settings and custom label for pipeline aggs#69688
sulemanof merged 6 commits intoelastic:masterfrom
sulemanof:fix/agg_advanced_settings

Conversation

@sulemanof
Copy link
Copy Markdown
Contributor

@sulemanof sulemanof commented Jun 23, 2020 •
edited
Loading

Summary

Add missing advanced settings and custom label for metric pipeline aggregations.
Add functional tests to check appearance and functionality.

Fixes #69014
Fixes #69376

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@sulemanof sulemanof added :KibanaApp/fix-it-week regression release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.9.0 v8.0.0 labels Jun 24, 2020
@sulemanof sulemanof marked this pull request as ready for review June 24, 2020 07:25
@sulemanof sulemanof requested a review from a team June 24, 2020 07:25
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 24, 2020

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula
stratoula approved these changes Jun 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have tested it on chrome, both bugs are solved 🍪

@sulemanof
Copy link
Copy Markdown
Contributor Author

sulemanof commented Jun 25, 2020

@elasticmachine merge upstream

@sulemanof
Copy link
Copy Markdown
Contributor Author

sulemanof commented Jun 26, 2020

Note: Sibling Pipeline aggregation is only available to change Custom label for the sub metric (1) or for the whole aggregation (2):
custom label

Possible cases:

  • custom labels both are not defined: chart label and axis -> Overall Average of Count (where Count is sub metric agg);
  • custom label for sub metric - Cats, custom metric for the whole agg is not defined: chart label and axis -> Overall Average of Cats ;
  • custom metric for the whole agg defined - Cats, in that case it skips other custom labels: chart label and axis -> Cats

The Custom label for sub bucket was hidden, since it didn't have any effect for calculating labels in previous Kibana versions: 7.0.0

image

@timroes what are your thoughts on that?

@sulemanof
Copy link
Copy Markdown
Contributor Author

sulemanof commented Jun 29, 2020

@elasticmachine merge upstream

@timroes
Copy link
Copy Markdown
Contributor

timroes commented Jun 29, 2020

@sulemanof that solutions looks great for me, thanks.

@sulemanof
Copy link
Copy Markdown
Contributor Author

sulemanof commented Jun 30, 2020

@markov00 are you OK with these changes?

@sulemanof
Copy link
Copy Markdown
Contributor Author

sulemanof commented Jul 2, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 2, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit a8347fa into elastic:master Jul 2, 2020
@sulemanof sulemanof deleted the fix/agg_advanced_settings branch July 2, 2020 10:24
@sulemanof sulemanof mentioned this pull request Jul 2, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 2, 2020
@gmmorris
Merge branch 'master' into alerting/built-in-alerts-feature
0e001e6 
* master: (46 commits)
  [Visualize] Add missing advanced settings and custom label for pipeline aggs (elastic#69688)
  Use dynamic: false for config saved object mappings (elastic#70436)
  [Ingest Pipelines] Error messages (elastic#70167)
  [APM] Show transaction rate per minute on Observability Overview page (elastic#70336)
  Filter out error when calculating a label (elastic#69934)
  [Visualizations] Each visType returns its supported triggers (elastic#70177)
  [Telemetry] Report data shippers (elastic#64935)
  Reduce SavedObjects mappings for Application Usage (elastic#70475)
  [Lens] fix dimension label performance issues (elastic#69978)
  Skip failing endgame tests (elastic#70548)
  [SIEM] Reenabling Cypress tests (elastic#70397)
  [SIEM][Security Solution][Endpoint] Endpoint Artifact Manifest Management + Artifact Download and Distribution (elastic#67707)
  [Security] Adds field mapping support to rule creation (elastic#70288)
  SECURITY-ENDPOINT: add fields for events to metadata document (elastic#70491)
  Fixed assertion in hybrid index pattern test to iterate through indices (elastic#70130)
  [SIEM][Exceptions] - Exception builder component (elastic#67013)
  [Ingest Manager] Rename data sources to package configs (elastic#70259)
  skip suites blocking es snapshot promomotion (elastic#70532)
  [Metrics UI] Fix asynchronicity and error handling in Snapshot API (elastic#70503)
  fix export response (elastic#70473)
  ...
sulemanof added a commit that referenced this pull request Jul 2, 2020
@sulemanof @elasticmachine
[Visualize] Add missing advanced settings and custom label for pipeli…
1f7c722 
…ne aggs (#69688) (#70573)

* Show advanced settings in pipeline aggs

* Add functional tests

* Make sub metric in sibling pipeline to have custom label

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@lukeelmers lukeelmers mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

@markov00 markov00 Awaiting requested review from markov00

@timroes timroes Awaiting requested review from timroes

Assignees

No one assigned

Labels

regression release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot define Custom Label for Sibling pipeline aggregations metrics on all visualizations [Visualize] Missing advanced JSON on pipeline aggregations

5 participants

@sulemanof @elasticmachine @timroes @kibanamachine @stratoula