Skip to content

Comments

[7.x] [APM] Add support for dark mode (#69362)#69622

Merged
sorenlouv merged 1 commit intoelastic:7.xfrom
sorenlouv:backport/7.x/pr-69362
Jun 21, 2020
Merged

[7.x] [APM] Add support for dark mode (#69362)#69622
sorenlouv merged 1 commit intoelastic:7.xfrom
sorenlouv:backport/7.x/pr-69362

Conversation

@sorenlouv
Copy link
Member

Backports the following commits to 7.x:

@sorenlouv sorenlouv added the backport This PR is a backport of another PR label Jun 19, 2020
@sorenlouv sorenlouv force-pushed the backport/7.x/pr-69362 branch from 26dfecb to 1fb00c4 Compare June 20, 2020 18:58
* Use theme colors for stacktrace

* [APM] Use theme for all components

* Switch HoC withTheme to useTheme and convert classes to hooks

* Change hardcoded white to euiColorEmptyShade for ServiceMap

* Snapshots and Legends fix

* Switch to context and add test helper

* Fix tests and update snaps

* New snaps + new anomaly detection

* Remove shallow from testHelpers

* Remove commented tests

* Fix prettier

* Pass correct theme to cytoscape

* Fix ServiceMap

* fixes some rendering issues in service maps

* removed the old anomaly detection logic from service map popover contents, since it's been moved to a new component.

* Fix eslint, tsc lint issues and unit tests

* Remove types for styled-components default theme

* Update x-pack/plugins/apm/public/components/shared/KueryBar/Typeahead/Suggestions.js

Co-authored-by: Casper Hübertz <casper@formgeist.com>

* fix OuterTheme

* Ise function declaration instead of expression

Co-authored-by: Balthazar Gronon <git@balthazar.dev>
Co-authored-by: Balthazar Gronon <bgronon@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Oliver Gupte <olivergupte@gmail.com>
Co-authored-by: Casper Hübertz <casper@formgeist.com>
# Conflicts:
#	x-pack/plugins/apm/public/components/app/ServiceMap/index.tsx
#	x-pack/plugins/apm/public/components/shared/charts/Timeline/Marker/__snapshots__/AgentMarker.test.tsx.snap
@sorenlouv sorenlouv force-pushed the backport/7.x/pr-69362 branch from 4b8cc01 to 7f92509 Compare June 21, 2020 12:26
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

  • 💚 Build #55355 succeeded 4b8cc0197c4bd7c7f6b5a1fad4d5734219f3b21a
  • 💔 Build #55352 failed 1fb00c4110382af66c251c2aeea2f80465079709
  • 💔 Build #55322 failed 26dfecb0f2a7b5ce8f2efada3619b21ccee908b3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 00e12fd into elastic:7.x Jun 21, 2020
@sorenlouv sorenlouv deleted the backport/7.x/pr-69362 branch June 21, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants