Skip to content

Conversation

@afgomez
Copy link
Contributor

@afgomez afgomez commented Jun 18, 2020

Summary

Add an action menu to the category examples in the log entry categorization page.

Screenshot 2020-06-26 at 17 33 40

Closes #68439

Checklist

Delete any items that are not applicable to this PR.

@afgomez afgomez added release_note:enhancement v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels Jun 18, 2020
@sgrodzicki sgrodzicki added this to the Logs UI 7.9 milestone Jun 24, 2020
@afgomez afgomez force-pushed the 68439-log-category-example-menu branch from 7af17e7 to d45e591 Compare June 25, 2020 18:52
@afgomez afgomez force-pushed the 68439-log-category-example-menu branch from d45e591 to c70c8c8 Compare June 26, 2020 10:51
@afgomez afgomez marked this pull request as ready for review June 29, 2020 14:56
@afgomez afgomez requested a review from a team as a code owner June 29, 2020 14:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez
Copy link
Contributor Author

afgomez commented Jul 6, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@weltenwort weltenwort changed the title [LogsUI] Actions menu in log entry categorization page [Logs UI] Actions menu in log entry categorization page Jul 6, 2020
@Kerry350 Kerry350 self-requested a review July 6, 2020 18:02
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I've approved, but can we add the href first then this is good to go.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit 21fc56e into elastic:master Jul 7, 2020
@afgomez afgomez deleted the 68439-log-category-example-menu branch July 7, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Logs UI Logs UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Logs UI] Link from log category examples to associated stream and context views

5 participants