[internal] Replace var with const/let in ui/public/utils/lodash-mixins#6936
Merged
epixa merged 1 commit intoelastic:masterfrom Apr 15, 2016
Merged
[internal] Replace var with const/let in ui/public/utils/lodash-mixins#6936epixa merged 1 commit intoelastic:masterfrom
epixa merged 1 commit intoelastic:masterfrom
Conversation
This change was applied only to files in src/ui/public/utils/lodash-mixins directory. All instances of var were replaced with let, and then all instances of let that wouldn't flag the no-const-assign rule in the linter were replaced with const.
Contributor
Author
|
jenkins, test it |
Contributor
Author
|
Almost done. I have to do the utils directory piece by piece because something is definitely not working with a blanket replace in this directory. |
Contributor
|
LGTM |
Contributor
|
LGTM! |
epixa
added a commit
that referenced
this pull request
Apr 15, 2016
--------- **Commit 1:** [internal] Replace var with const/let in ui/public/utils/lodash-mixins This change was applied only to files in src/ui/public/utils/lodash-mixins directory. All instances of var were replaced with let, and then all instances of let that wouldn't flag the no-const-assign rule in the linter were replaced with const. * Original sha: 18e9725 * Authored by Court Ewing <court@epixa.com> on 2016-04-14T18:32:49Z
elastic-jasper
added a commit
that referenced
this pull request
Apr 15, 2016
--------- **Commit 1:** [internal] Replace var with const/let in ui/public/utils/lodash-mixins This change was applied only to files in src/ui/public/utils/lodash-mixins directory. All instances of var were replaced with let, and then all instances of let that wouldn't flag the no-const-assign rule in the linter were replaced with const. * Original sha: 18e9725 * Authored by Court Ewing <court@epixa.com> on 2016-04-14T18:32:49Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was applied only to files in
src/ui/public/utils/lodash-mixins directory.
All instances of var were replaced with let, and then all instances
of let that wouldn't flag the no-const-assign rule in the linter were
replaced with const.