[Metrics UI] Prefill alerts from the global dropdown by Zacqary · Pull Request #68967 · elastic/kibana

Zacqary · 2020-06-11T21:50:46Z

Summary

Metric Threshold and Inventory alerts will now pre-populate based on your current filters when you create an alert from the Alerts dropdown:

When you see this Inventory screen

The alert prefills with this

From this Metrics Explorer

To this alert

elasticmachine · 2020-06-11T21:50:48Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

# Conflicts: # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx

Zacqary · 2020-06-17T19:30:16Z

@elasticmachine merge upstream

simianhacker

Everything looks really good.

I want to start making an effort to start filling in some of the test coverage for our app. As a team (I'm probably the most guilty) we've been really laxed about testing, I want to work on changing that.

In that spirit, I added some comments about updating a test and adding tests for some of the hooks that don't have them. For some of the hooks that don't have tests where we've added the useAlertPrefillContext() it's ok to set up the minimum to just test the new code. If you have the extra time and want to fill in test for the rest of the functionality, that would really be appreciated but it's not required since technically it's out of the scope of this PR. Eventually, we will need to fill those in but that can be done later as "tech debt" cleanup.

...ck/plugins/infra/public/pages/metrics/metrics_explorer/hooks/use_metrics_explorer_options.ts

x-pack/plugins/infra/public/pages/metrics/inventory_view/hooks/use_waffle_options.ts

x-pack/plugins/infra/public/pages/metrics/inventory_view/hooks/use_waffle_filters.ts

x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx

…60659-alert-prefill

# Conflicts: # x-pack/plugins/infra/public/pages/metrics/index.tsx

mikecote

Triggers actions UI code LGTM. Great seeing UX enhancements like this :)

Zacqary · 2020-06-23T16:02:05Z

@elasticmachine merge upstream

Zacqary · 2020-06-23T16:58:29Z

@simianhacker Added all the tests you requested. New test files are just testing the new prefill functionality in this PR, but there's a framework to fill them out when we cover tech debt

simianhacker · 2020-06-23T20:13:54Z

For some reason this PR shows two headers:

and on the Metrics Explorer page I'm getting this error:

Zacqary · 2020-06-23T20:35:24Z

@simianhacker Looks like a bad merge conf resolution, I'll fix

# Conflicts: # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx

kibanamachine · 2020-06-24T18:41:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5c80011

Build metrics

✅ unchanged

History

💔 Build #55966 failed 86b915f
💚 Build #55706 succeeded e730aa9
💔 Build #55658 failed e5f7318
💔 Build #55635 failed 550e476
💔 Build #55608 failed 8809d7c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

simianhacker

LGTM

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…69981) * [Metrics UI] Prefill alerts from the global dropdown (#68967) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Fix uncaught typecheck merge conflict Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

sorantis · 2020-07-29T11:45:44Z

Conditions disappear from the flyout if I remove the queried metrics.

Zacqary added 2 commits June 11, 2020 16:06

Add metric threshold global prefill

56dfd18

Add inventory alert prefill

ef863c6

Zacqary added release_note:enhancement Feature:Alerting Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels Jun 11, 2020

Zacqary requested a review from a team as a code owner June 11, 2020 21:50

Zacqary added 3 commits June 12, 2020 11:09

Fix jest

016442c

Merge remote-tracking branch 'upstream/master' into 60659-alert-prefill

95081c0

Merge remote-tracking branch 'upstream/master' into 60659-alert-prefill

983b8f6

# Conflicts: # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx

Merge branch 'master' into 60659-alert-prefill

3dc2522

simianhacker self-requested a review June 17, 2020 19:34

simianhacker requested changes Jun 17, 2020

View reviewed changes

Zacqary added 7 commits June 18, 2020 12:49

Add metric prefill test to useMetricExplorerOptions

2d78353

Switch thres metric options test to jest.mock; add waffle filter test

f0394e8

Merge branch '60659-alert-prefill' of github.com:Zacqary/kibana into …

9148b35

…60659-alert-prefill

Merge remote-tracking branch 'upstream/master' into 60659-alert-prefill

e24405f

# Conflicts: # x-pack/plugins/infra/public/pages/metrics/index.tsx

Add waffle options test

5f00cc1

Commit missing files

bdf9b90

Expression component test WIP

dd4eab4

Zacqary requested a review from a team as a code owner June 18, 2020 22:03

mikecote approved these changes Jun 23, 2020

View reviewed changes

elasticmachine and others added 2 commits June 23, 2020 10:02

Merge branch 'master' into 60659-alert-prefill

d6200a1

Add Expression enzyme test for prefill

8809d7c

Zacqary added 2 commits June 23, 2020 13:03

Fix typecheck

550e476

Fix bad merge

e5f7318

Zacqary added 3 commits June 23, 2020 15:58

Fix bad merge and metrics explorer infinite loop

e730aa9

Merge remote-tracking branch 'upstream/master' into 60659-alert-prefill

86b915f

# Conflicts: # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx

Fix bad merge

5c80011

simianhacker approved these changes Jun 24, 2020

View reviewed changes

Zacqary merged commit 71ea1a0 into elastic:master Jun 25, 2020

Zacqary deleted the 60659-alert-prefill branch June 25, 2020 17:01

Zacqary mentioned this pull request Jun 25, 2020

[7.x] [Metrics UI] Prefill alerts from the global dropdown (#68967) #69981

Merged

Zacqary added a commit to Zacqary/kibana that referenced this pull request Jun 25, 2020

[Metrics UI] Prefill alerts from the global dropdown (elastic#68967)

87642a5

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Zacqary mentioned this pull request Jun 25, 2020

Fix uncaught typecheck merge conflict #70001

Merged

sorantis mentioned this pull request Jul 29, 2020

[Metrics UI] Threshold Alerts: Conditions disappear after removing the queried metrics #73698

Closed

Conversation

Zacqary commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

When you see this Inventory screen

The alert prefills with this

From this Metrics Explorer

To this alert

Uh oh!

elasticmachine commented Jun 11, 2020

Uh oh!

Zacqary commented Jun 17, 2020

Uh oh!

simianhacker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mikecote left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zacqary commented Jun 23, 2020

Uh oh!

Zacqary commented Jun 23, 2020

Uh oh!

simianhacker commented Jun 23, 2020

Uh oh!

Zacqary commented Jun 23, 2020

Uh oh!

kibanamachine commented Jun 24, 2020

💚 Build Succeeded

Build metrics

History

Uh oh!

simianhacker left a comment

Choose a reason for hiding this comment

Uh oh!

sorantis commented Jul 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

Zacqary commented Jun 11, 2020 •

edited

Loading

mikecote left a comment •

edited

Loading