[TSVB] Add support for histogram type#68837
Merged
simianhacker merged 18 commits intoelastic:masterfrom Jul 13, 2020
Merged
Conversation
simianhacker
added
release_note:enhancement
Feature:TSVB
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
3 tasks
…svb-support-for-histograms
…svb-support-for-histograms
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
alexwizp
reviewed
Jun 24, 2020
alexwizp
reviewed
Jun 24, 2020
| @@ -0,0 +1,84 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
nit: we already started migration js -> ts. If possible please refactor tests in ts
Member
There was a problem hiding this comment.
@alexwizp are all of the imported files already migrated to TS? Maybe we can hold off here for now if not?
Contributor
|
Code looks good, tested on the following test snippet Visualizations in TSVB and Area visualization looks similar TSVB: Area: |
alexwizp
reviewed
Jun 24, 2020
| import { Percentiles, newPercentile } from './percentile_ui'; | ||
|
|
||
| const RESTRICT_FIELDS = [KBN_FIELD_TYPES.NUMBER]; | ||
| const RESTRICT_FIELDS = [KBN_FIELD_TYPES.NUMBER, KBN_FIELD_TYPES.HISTOGRAM]; |
Contributor
There was a problem hiding this comment.
I think KBN_FIELD_TYPES.HISTOGRAM should be also added for src/plugins/vis_type_timeseries/public/application/components/aggs/filter_ratio.js
Member
Author
There was a problem hiding this comment.
Filter ratio doesn't have a field dropdown.
Contributor
There was a problem hiding this comment.
You should change Metric Aggregation ftom Count to Average for example
Member
Author
There was a problem hiding this comment.
Oops... I forgot about that feature. Adding it now.
…svb-support-for-histograms
Member
Author
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
Member
|
@alexwizp we're looking to get this in for 7.9 -- are you the right person to ping for a review? |
Member
|
hey @jasonrhodes, I'll put this in the team channel and also ping @timroes and @stratoula |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
Now, I see that when we choose the filter ratio aggregation, whatever agg we select on the metric aggregation dropdown, the field dropdown has the histogram type fields. For example:
I think that |
Contributor
|
@stratoula Yes, the only supported aggregations are: https://www.elastic.co/guide/en/elasticsearch/reference/master/histogram.html#histogram-uses. We should not allow the user to create an aggregation that will then fail in ES. |
Contributor
|
Thanx @timroes :) @simianhacker can you also take care of this? We are getting really close 🎉 |
Member
Author
|
@stratoula Everything should be done. I also took care of #70984 since it's pretty much the same solution as what we need to limit the aggregations for the histogram fields. I contemplated changing the property name for |
Contributor
|
@simianhacker great! Thanx for solving the bug of the filter_ratio aggs. Add the What do you think? |
Contributor
|
@elasticmachine merge upstream |
stratoula
approved these changes
Jul 13, 2020
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Perfect!! 🎉 LGTM, thanks a lot @simianhacker!
Contributor
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jul 13, 2020
* [TSVB] Add support for histogram type * Merge branch 'master' of github.com:elastic/kibana into issue-52426-tsvb-support-for-histograms * Adding support to filter ratio; updating test * Limist aggs for filter_ratio and histogram fields; add test for AggSelect; Fixes elastic#70984 * Ensure only compatible fields are displayed for filter ratio metric aggs Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
simianhacker
added a commit
that referenced
this pull request
Jul 13, 2020
* [TSVB] Add support for histogram type * Merge branch 'master' of github.com:elastic/kibana into issue-52426-tsvb-support-for-histograms * Adding support to filter ratio; updating test * Limist aggs for filter_ratio and histogram fields; add test for AggSelect; Fixes #70984 * Ensure only compatible fields are displayed for filter ratio metric aggs Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/management/_create_index_pattern_wizard·js.management "Create Index Pattern" wizard data streams can be an index patternStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/management/_create_index_pattern_wizard·js.management "Create Index Pattern" wizard data streams can be an index patternStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_filter_bar·js.dashboard app using current data dashboard filter bar filter editor field list shows index pattern of vis when one is addedStandard OutStack TraceBuild metrics
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for histogram types to the following TSVB aggregations:
Testing Data
See #52426 for details
Fixes #70984
Checklist