Skip to content

[Maps] Fix mb-style interpolate style rule #68413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasneirynck merged 3 commits into from
Jun 5, 2020
Merged

[Maps] Fix mb-style interpolate style rule #68413

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
004d4ff
do not interpolate between identical range
thomasneirynck Jun 5, 2020
4439e23
add unit test
thomasneirynck Jun 5, 2020
65a825e
fix typing
thomasneirynck Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_size_property.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ export class DynamicSizeProperty extends DynamicStyleProperty {

_getMbDataDrivenSize({ targetName, minSize, maxSize, minValue, maxValue }) {
const lookup = this.supportsMbFeatureState() ? 'feature-state' : 'get';

const stops =
minValue === maxValue ? [minValue, minSize] : [minValue, minSize, maxValue, maxSize];
Comment thread
thomasneirynck marked this conversation as resolved.
Outdated
return [
'interpolate',
['linear'],
Expand All @@ -120,10 +123,7 @@ export class DynamicSizeProperty extends DynamicStyleProperty {
fieldName: targetName,
fallback: 0,
}),
minValue,
minSize,
maxValue,
maxSize,
...stops,
];
}

Expand Down