[notify] conditionally include the config service#6826
Merged
spalger merged 2 commits intoelastic:masterfrom Apr 11, 2016
Merged
[notify] conditionally include the config service#6826spalger merged 2 commits intoelastic:masterfrom
spalger merged 2 commits intoelastic:masterfrom
Conversation
src/ui/public/notify/notify.js
Outdated
| const shouldSetupConfig = !!kbnIndex; | ||
| if (shouldSetupConfig) { | ||
| require('ui/config'); | ||
| module.run(function ($interval, $rootScope, $injector, config) { |
Member
There was a problem hiding this comment.
$injector is not being used
Member
|
To manually test all of the alert types I add the following into discover.js notify.error('an error');
notify.warning('a warning');
notify.info('some info');However that is now throwing an illegal invocation because setInterval not being set on config. |
Member
|
Looks good! |
cee-chen
added a commit
that referenced
this pull request
Jun 3, 2023
This is a backport EUI upgrade to Kibana v8.8.1 containing an `EuiCodeBlock` bugfix requested by the Observability team: #158644 (comment) ## [`77.1.5`](https://github.com/elastic/eui/tree/v77.1.5) **Bug fixes** - Fixed `EuiCodeBlock` potentially incorrectly ignoring lines ending with a question mark when using the Copy button. ([#6794](elastic/eui#6794)) - Fixed `EuiCodeBlock` to not include line numbers when copying content ([#6824](elastic/eui#6824)) - Fixed the expanded row animation on `EuiBasicTable` causing cross-browser Safari issues ([#6826](elastic/eui#6826)) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cee-chen
added a commit
that referenced
this pull request
Jun 6, 2023
## Summary `eui@81.2.0` ⏩ `eui@81.3.0` ✨ Highlights: - fixes #158644 - Adds a new Timeline icon for use within `EuiMarkdownEditor` (cc @kqualters-elastic) - Expandable rows used within `EuiBasicTable` and `EuiInMemoryTable` now have a faster and snappier expand animation ___ ## [`81.3.0`](https://github.com/elastic/eui/tree/v81.3.0) - Added `timelineWithArrow` glyph to `EuiIcon` ([#6822](elastic/eui#6822)) **Bug fixes** - Fixed `EuiCodeBlock` potentially incorrectly ignoring lines ending with a question mark when using the Copy button. ([#6794](elastic/eui#6794)) - Fixed `EuiCodeBlock` to not include line numbers when copying content ([#6824](elastic/eui#6824)) - Fixed the expanded row animation on `EuiBasicTable` causing cross-browser Safari issues ([#6826](elastic/eui#6826))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #6364 the notifier has been configurable via the front-end config service, which currently requires Kibana. Since the notifier is designed to be agnostic to the application/implementation, and shouldn't require Kibana, we need to make the hook into angular optional.
☁️