Skip to content

[APM] Fixes e2e testing by matching stack version with kibana #68198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorenlouv merged 1 commit into from
Jun 4, 2020
Merged

[APM] Fixes e2e testing by matching stack version with kibana #68198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion x-pack/plugins/apm/e2e/run-e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ APM_IT_DIR="./tmp/apm-integration-testing"

cd ${E2E_DIR}

KIBANA_VERSION=$(node -p "require('../../../package.json').version")
Copy link
Copy Markdown
Contributor Author

@ogupte ogupte Jun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a better way to get the stack version?


#
# Ask user to start Kibana
##################################################
Expand Down Expand Up @@ -63,7 +65,8 @@ fi

# Start apm-integration-testing
echo "Starting docker-compose"
${APM_IT_DIR}/scripts/compose.py start master \
echo "Using stack version: ${KIBANA_VERSION}"
${APM_IT_DIR}/scripts/compose.py start $KIBANA_VERSION \
--no-kibana \
--elasticsearch-port $ELASTICSEARCH_PORT \
--apm-server-port=$APM_SERVER_PORT \
Expand Down