[Console]remove completion for type for filter queries and aggs

[hendrikmuhs]

Summary

remove suggesting "type" for filter queries and aggregations, because "type"
got removed in the backend.

How to test

Start Kibana and navigate to Console. Type a query that contains a filter, type should no longer be suggested. Example:

GET _search
{
  "query": {
    "bool": {
      "filter": [
        {
          "t"
          }
        }
      ]
    }
  }
}

Note: In 7.x the type query is deprecated and it's highly discouraged to use it, I leave it up to you to decide whether to backport this change or not.

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: d2613f7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[jloleysens]

Great work @hendrikmuhs ! Thanks for cleaning that up.

I tested locally and everything looks to be in good order.

I noticed that in mappings there is completion support for _parent with a type on it:

PUT an-index
{
  "mappings": {
    "_parent": {
      "type": ""
    }
  }
}

I could not see this field in the ES docs for 7.7, do you know whether it should be removed too? No need to block merging on this :)

[hendrikmuhs]

I noticed that in mappings there is completion support for _parent with a type on it:

PUT an-index
{
  "mappings": {
    "_parent": {
      "type": ""
    }
  }
}

I could not see this field in the ES docs for 7.7, do you know whether it should be removed too? No need to block merging on this :)

I think this type corresponds to a data type, not the deprecated/removed doc type.

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 68103 or prevent reminders by adding the backport:skip label.

[cjcenizal]

Here are my thoughts in response to Hendrik's very good question.

I see the current form of Console acting as an unopinionated window into the Elasticsearch APIs. I think it exists to support accessing these APIs with tools like autocomplete and XJSON. I think we should consider UX enhancements like warnings (e.g. #39491), but it seems against the spirit of Console to hide aspects of Elasticsearch, even if they are deprecated. I think someone who tries to access type would be surprised to find it missing from autocomplete, and possibly file a bug report. If we truly don't want users to use parts of Elasticsearch's API, I think the solution we'd reach for is to remove those parts from the API.