Merged
Conversation
* branding updates * update snapshots * update loginPage snapshot * removed unused EuiText imports * update button label for exiting full screen * remove unused translations * update loading_news snapshot * update functional baseline screenshots # Conflicts: # src/core/public/chrome/ui/header/header_logo.tsx # x-pack/plugins/translations/translations/zh-CN.json
alexfrancoeur
changed the title
Contributor
Author
|
@myasonik I need your help sorting this out in the morning. I updated some snapshots, but I'm not sure that was the right thing to do. If it was, then it seems there might be more to update... but its not clear to me why I would need to update them. Something feels 'off' and I want to be sure I'm following your recent header test changes. I think I need to do something like:
|
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
The failing tests passed locally, so re-running it here. |
ryankeairns
force-pushed
the
backport/7.8/pr-64712
branch
from
0accf56 to
5609dca
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68000
Backports the following commits to 7.8: