[kbn/optimizer] use execa to fork workers#67730
Merged
spalger merged 2 commits intoelastic:masterfrom May 29, 2020
Merged
Conversation
spalger
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
May 29, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
May 29, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jun 16, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com> (cherry picked from commit 6288096)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternate attempt at a solution originally implemented in #67059. In this version of the PR we just use execa, which has a great reputation for consistently reaping the processes it starts. I'm not sure I understand it's magic, but I trust it and hope that it will help us avoid the unlikely chance that workers get left around forever.