Updating the licensed feature usage API response format #67712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
added
v8.0.0
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
joshdover
approved these changes
Jun 1, 2020
Contributor
joshdover
left a comment
joshdover
left a comment
There was a problem hiding this comment.
Changes LGTM. I'm assuming at this point, we still don't have any consumers of this API within Kibana?
Contributor
Author
|
Not yet, #67526 would be the first |
This was referenced Jun 1, 2020
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Jun 1, 2020
kobelb
added a commit
that referenced
this pull request
Jun 1, 2020
) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FeatureUsageServiceSetup::registerhas been changed fromregister(featureName: string): void;toregister(featureName: string, licenseType: LicenseType): void;so we can also return the license level.Currently, this is using the
featureNameas a unique identifier, but it's also supposed to be human-readable. This is somewhat awkward, but it felt equally awkward to introduce a name in addition to an identifier, when both are intended to be unique... Differing opinions or suggestions are welcome!Resolves #67682