[Discover] Improve a11y test when switching to context #67363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Feature:Discover
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
Would you please unskip the tests as they were skipped in #62497. We should also get some flaky test runs on this once it's updated with master/unskips. |
…-26-improve-discover-context-a11y-test
…-26-improve-discover-context-a11y-test
Member
|
@elasticmachine merge upstream |
Member
Author
Member
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
May 29, 2020
kertal
added a commit
to kertal/kibana
that referenced
this pull request
May 29, 2020
kertal
added a commit
that referenced
this pull request
May 29, 2020
kertal
added a commit
that referenced
this pull request
May 29, 2020
kertal
deleted the
kertal-pr-2020-05-26-improve-discover-context-a11y-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seems PR #66959 didn't solve all flakiness of Discover's a11y tests, trying to switch to the context view. So I'm adding also the click to expand a row of the data table in Discover to the retry section, since the failure screens show an unexpanded table of records.
Checklist