Skip to content

remove unused server.uuid mapping #66963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2020
Merged

remove unused server.uuid mapping #66963

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e68d58f
server.uuid so is not used
mshustov May 19, 2020
e47e144
Merge branch 'master' into remove-unuses-server-uuid
elasticmachine May 19, 2020
6e7070f
Merge branch 'master' into remove-unuses-server-uuid
elasticmachine May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/core/server/core_app/core_app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,6 @@ export class CoreApp {
router.get({ path: '/core', validate: false }, async (context, req, res) =>
res.ok({ body: { version: '0.0.1' } })
);

coreSetup.savedObjects.registerType({
Copy link
Contributor Author

@mshustov mshustov May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rudolf can it create any problem during migration? Should we delete this SO?

Copy link
Contributor

@rudolf rudolf May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as there's no dependency on the type, removing a registered type is safe even if an index has existing objects of that type. I'm not aware of any dependency on this either.

name: 'server',
hidden: false,
namespaceType: 'single',
mappings: {
properties: {
uuid: { type: 'keyword' },
},
},
});
}
private registerStaticDirs(coreSetup: InternalCoreSetup) {
coreSetup.http.registerStaticDir('/ui/{path*}', Path.resolve(__dirname, './assets'));
Expand Down