Skip to content

Comments

[7.x] [SIEM] [Maps] Fixes Network Map empty tooltip (#66828)#66945

Merged
spong merged 1 commit intoelastic:7.xfrom
spong:backport/7.x/pr-66828
May 19, 2020
Merged

[7.x] [SIEM] [Maps] Fixes Network Map empty tooltip (#66828)#66945
spong merged 1 commit intoelastic:7.xfrom
spong:backport/7.x/pr-66828

Conversation

@spong
Copy link
Member

@spong spong commented May 19, 2020

Backports the following commits to 7.x:

## Summary

Resolves elastic#63474, and expands `ITooltipProperty`'s `rawValue` type to include `string[]` as mentioned [here](elastic#61264 (comment)).

![image](https://user-images.githubusercontent.com/2946766/82100568-2c0e1480-96c7-11ea-958e-5b1c6b6a3db9.png)



### Checklist

Delete any items that are not applicable to this PR.

- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
@spong spong added the backport This PR is a backport of another PR label May 19, 2020
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Configures a new connector.Cases connectors Configures a new connector

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 17 times on tracked branches: https://github.com/elastic/kibana/issues/65278


Stack Trace

AssertionError: Timed out retrying: Expected to find element: `[data-test-subj='dropdown-connector-e8026d49-feb7-4711-a5a1-7a6afcb897f8']`, but never found it.
    at ensureExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:137438:32)
    at Object.ensureElExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:137456:12)
    at ensureExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:127861:23)
    at onFailFn (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:127899:9)
    at tryCatcher (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:9059:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:6994:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7051:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7096:10)
    at Promise._settlePromises (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7172:18)
    at _drainQueueStep (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3766:12)
    at _drainQueue (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3759:9)
    at Async.../../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3775:5)
    at Async.drainQueues (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3645:14)

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spong spong merged commit 3dbe9dc into elastic:7.x May 19, 2020
@spong spong deleted the backport/7.x/pr-66828 branch May 19, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants