Cleanup yarn.lock from duplicates #66617

Other than one concern about the removal of ^ version ranges I think this is a great improvement from the operations perspective! Thanks for putting the work in @patrykkopycinski!

package.json

mshustov

ok for platform changes

sebelga

LGTM for es_ui. Curious why the test snapshot needed to be updated with "shards" though.

x-pack/plugins/infra/public/containers/logs/log_entries/index.ts

spalger

LGTM!

mistic · 2020-10-02T20:45:53Z

@elasticmachine merge upstream

spalger · 2020-10-03T04:09:19Z

@elasticmachine merge upstream

kibanamachine · 2020-10-03T04:09:21Z

merge conflict between base and head

…ck-deduplicate # Conflicts: # yarn.lock

kibanamachine · 2020-10-03T09:50:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4707b91

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`apm`	1257	1276	+19
`canvas`	1133	1132	-1
`charts`	38	39	+1
`core`	438	441	+3
`dashboard`	171	170	-1
`infra`	1145	1147	+2
`ingestManager`	542	544	+2
`kibanaReact`	291	293	+2
`kibanaUtils`	191	193	+2
`lens`	562	563	+1
`maps`	744	618	-126
`ml`	1216	1222	+6
`security`	456	458	+2
`visTypeTimeseries`	465	466	+1
total			-87

@kbn/ui-shared-deps asset size

id	before	after	diff
`[email protected]`	2.9MB	2.8MB	-29.5KB
`kbn-ui-shared-deps.js`	5.2MB	4.6MB	-562.3KB
total			-591.8KB

async chunks size

id	before	after	diff
`advancedSettings`	892.1KB	891.9KB	-143.0B
`apm`	4.1MB	4.2MB	+21.5KB
`canvas`	1.5MB	1.5MB	-195.0B
`console`	1.1MB	1.1MB	-1.5KB
`core`	290.6KB	258.3KB	-32.3KB
`discover`	430.7KB	429.6KB	-1.1KB
`enterpriseSearch`	430.2KB	428.6KB	-1.5KB
`graph`	1.3MB	1.3MB	-24.0B
`home`	413.8KB	413.6KB	-144.0B
`indexLifecycleManagement`	231.8KB	231.7KB	-144.0B
`indexManagement`	1.6MB	1.6MB	-432.0B
`indexPatternManagement`	662.8KB	662.3KB	-575.0B
`infra`	4.1MB	3.8MB	-303.1KB
`ingestManager`	1.1MB	1.1MB	-32.9KB
`ingestPipelines`	814.3KB	812.9KB	-1.4KB
`kibanaLegacy`	147.1KB	146.9KB	-144.0B
`kibanaReact`	391.5KB	358.4KB	-33.1KB
`kibanaUtils`	158.6KB	125.8KB	-32.8KB
`lens`	1.1MB	1.1MB	-209.0B
`management`	33.8KB	33.5KB	-288.0B
`maps`	3.3MB	3.2MB	-88.3KB
`mapsLegacy`	731.3KB	731.2KB	-107.0B
`ml`	10.5MB	10.6MB	+32.6KB
`monitoring`	1.2MB	1.2MB	-2.7KB
`observability`	163.4KB	163.2KB	-288.0B
`remoteClusters`	228.0KB	227.8KB	-144.0B
`rollup`	323.4KB	323.3KB	-144.0B
`savedObjectsManagement`	207.0KB	206.9KB	-144.0B
`searchprofiler`	705.0KB	705.1KB	+51.0B
`security`	1.0MB	1.0MB	-34.3KB
`securitySolution`	10.4MB	10.3MB	-35.8KB
`spaces`	45.9KB	45.5KB	-432.0B
`timelion`	461.6KB	461.4KB	-144.0B
`transform`	1.2MB	1.2MB	+51.0B
`triggers_actions_ui`	1.5MB	1.5MB	-2.5KB
`visDefaultEditor`	409.7KB	409.7KB	-24.0B
`visTypeMarkdown`	12.9KB	12.8KB	-144.0B
`visTypeMetric`	27.2KB	27.1KB	-144.0B
`visTypeTagcloud`	295.4KB	295.3KB	-144.0B
`visTypeTimelion`	154.3KB	154.2KB	-144.0B
`visTypeTimeseries`	1.8MB	1.8MB	+3.4KB
`visTypeVega`	1.4MB	1.4MB	+409.0B
`visualize`	271.8KB	271.4KB	-432.0B
`watcher`	1.0MB	1.0MB	+51.0B
total			-549.9KB

distributable file count

id	before	after	diff
`default`	41240	44116	+2876
`oss`	24863	28595	+3732

page load bundle size

id	before	after	diff
`beatsManagement`	439.8KB	440.2KB	+315.0B
`canvas`	1.0MB	1.0MB	-576.0B
`charts`	137.4KB	140.8KB	+3.4KB
`console`	30.4KB	30.4KB	-24.0B
`core`	660.6KB	661.1KB	+484.0B
`dashboard`	569.9KB	570.2KB	+357.0B
`data`	1.3MB	1.3MB	+378.0B
`devTools`	23.2KB	23.1KB	-144.0B
`embeddable`	290.9KB	290.7KB	-143.0B
`esUiShared`	302.8KB	302.7KB	-144.0B
`expressions`	204.3KB	204.2KB	-67.0B
`indexManagement`	122.8KB	122.7KB	-143.0B
`indexPatternManagement`	136.1KB	136.0KB	-144.0B
`infra`	178.6KB	178.6KB	+26.0B
`ingestManager`	511.3KB	511.7KB	+469.0B
`inputControlVis`	154.1KB	154.0KB	-144.0B
`inspector`	130.9KB	130.6KB	-288.0B
`kibanaReact`	124.4KB	124.1KB	-262.0B
`kibanaUtils`	179.3KB	179.5KB	+180.0B
`lens`	76.0KB	76.0KB	+1.0B
`licenseManagement`	26.3KB	26.2KB	-144.0B
`maps`	164.6KB	164.4KB	-144.0B
`mapsLegacy`	99.6KB	99.4KB	-133.0B
`navigation`	22.1KB	21.9KB	-144.0B
`observability`	52.4KB	52.4KB	+11.0B
`painlessLab`	161.0KB	160.9KB	-144.0B
`rollup`	80.3KB	80.3KB	+1.0B
`savedObjects`	91.5KB	91.3KB	-144.0B
`savedObjectsManagement`	83.5KB	83.5KB	+1.0B
`searchprofiler`	50.9KB	50.9KB	-8.0B
`securitySolution`	587.2KB	587.1KB	-102.0B
`share`	80.0KB	79.9KB	-144.0B
`snapshotRestore`	62.7KB	62.5KB	-144.0B
`spaces`	345.5KB	343.9KB	-1.5KB
`transform`	25.5KB	25.4KB	-144.0B
`triggers_actions_ui`	148.1KB	148.0KB	-144.0B
`uiActions`	80.6KB	80.6KB	+1.0B
`uiActionsEnhanced`	321.0KB	320.7KB	-286.0B
`upgradeAssistant`	64.8KB	64.7KB	-144.0B
`visDefaultEditor`	34.4KB	34.4KB	+1.0B
`visTypeTable`	78.0KB	77.8KB	-144.0B
`visTypeTimeseries`	136.9KB	136.9KB	-24.0B
`visTypeVega`	134.2KB	134.0KB	-288.0B
`visTypeVislib`	222.8KB	222.7KB	-144.0B
`visualizations`	272.4KB	272.2KB	-144.0B
`watcher`	28.1KB	27.9KB	-144.0B
total			-762.0B

History

💔 Build #79331 failed 431203e
💚 Build #79119 succeeded b5974ae
💔 Build #79107 failed 3f18f03
💔 Build #79089 failed b8a15a9
💔 Build #79086 failed 210afe3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

# Conflicts: # packages/kbn-pm/dist/index.js # yarn.lock

* master: (128 commits) add core-js production dependency (elastic#79395) Add support for sharing saved objects to all spaces (elastic#76132) [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038) load js-yaml lazily (elastic#79092) skip flaky suite (elastic#77278) Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341) [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988) [Security Solutions][Detection Engine] Updates the edit rules page to:wq! only have what is selected for editing (elastic#79233) Cleanup yarn.lock from duplicates (elastic#66617) [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052) [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291) [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358) [babel/register] remove from build (take 2) (elastic#79379) [Security Solution] Changes rules table tag display (elastic#77102) define integrationTestRoot in config file and use to define screensho… (elastic#79247) Revert "[babel/register] remove from build (elastic#79176)" skip flaky suite (elastic#75241) [Uptime] Synthetics UI (elastic#77960) [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812) [babel/register] remove from build (elastic#79176) ...

* master: (288 commits) add core-js production dependency (elastic#79395) Add support for sharing saved objects to all spaces (elastic#76132) [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038) load js-yaml lazily (elastic#79092) skip flaky suite (elastic#77278) Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341) [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988) [Security Solutions][Detection Engine] Updates the edit rules page to only have what is selected for editing (elastic#79233) Cleanup yarn.lock from duplicates (elastic#66617) [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052) [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291) [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358) [babel/register] remove from build (take 2) (elastic#79379) [Security Solution] Changes rules table tag display (elastic#77102) define integrationTestRoot in config file and use to define screensho… (elastic#79247) Revert "[babel/register] remove from build (elastic#79176)" skip flaky suite (elastic#75241) [Uptime] Synthetics UI (elastic#77960) [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812) [babel/register] remove from build (elastic#79176) ...

patrykkopycinski added the release_note:skip Skip the PR/issue when compiling release notes label May 14, 2020

patrykkopycinski self-assigned this May 14, 2020

patrykkopycinski added the chore label May 15, 2020

patrykkopycinski requested review from spalger and stacey-gammon May 15, 2020 19:32

patrykkopycinski marked this pull request as ready for review May 15, 2020 19:33

patrykkopycinski requested a review from a team May 15, 2020 19:33

patrykkopycinski added v7.9.0 v8.0.0 labels May 15, 2020

patrykkopycinski requested a review from a team as a code owner May 15, 2020 20:04

spalger reviewed May 15, 2020

View reviewed changes

patrykkopycinski removed the request for review from stacey-gammon May 16, 2020 07:37

patrykkopycinski marked this pull request as draft May 16, 2020 07:38

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 16, 2020

patrykkopycinski marked this pull request as ready for review June 21, 2020 23:41

patrykkopycinski requested review from a team as code owners June 21, 2020 23:41

patrykkopycinski requested a review from spalger June 21, 2020 23:41

spalger reviewed Jun 23, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

mshustov approved these changes Jun 23, 2020

View reviewed changes

sebelga approved these changes Jun 23, 2020

View reviewed changes

patrykkopycinski force-pushed the chore/yarn-lock-deduplicate branch from 277fd3e to 210afe3 Compare October 2, 2020 09:50

patrykkopycinski requested a review from a team as a code owner October 2, 2020 09:50

dist

b8a15a9

weltenwort reviewed Oct 2, 2020

View reviewed changes

x-pack/plugins/infra/public/containers/logs/log_entries/index.ts Outdated Show resolved Hide resolved

patrykkopycinski marked this pull request as draft October 2, 2020 10:50

fix

3f18f03

patrykkopycinski removed v7.9.3 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 2, 2020

patrykkopycinski removed request for a team October 2, 2020 11:06

fix

b5974ae

patrykkopycinski marked this pull request as ready for review October 2, 2020 13:38

patrykkopycinski requested a review from spalger October 2, 2020 13:52

spalger approved these changes Oct 2, 2020

View reviewed changes

mistic approved these changes Oct 2, 2020

View reviewed changes

Merge branch 'master' into chore/yarn-lock-deduplicate

431203e

Merge branch 'master' of github.com:elastic/kibana into chore/yarn-lo…

4707b91

…ck-deduplicate # Conflicts: # yarn.lock

patrykkopycinski merged commit 8a8066f into elastic:master Oct 3, 2020

patrykkopycinski deleted the chore/yarn-lock-deduplicate branch October 3, 2020 09:53

patrykkopycinski added the v7.10.0 label Oct 3, 2020

patrykkopycinski mentioned this pull request Oct 3, 2020

[7.x] Cleanup yarn.lock from duplicates (#66617) #79385

Merged

patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Oct 3, 2020

Cleanup yarn.lock from duplicates (elastic#66617)

d1a2045

# Conflicts: # packages/kbn-pm/dist/index.js # yarn.lock

patrykkopycinski added a commit that referenced this pull request Oct 3, 2020

[7.x] Cleanup yarn.lock from duplicates (#66617) (#79385)

5477a1d

Cleanup yarn.lock from duplicates #66617

Cleanup yarn.lock from duplicates #66617

Uh oh!

Conversation

patrykkopycinski commented May 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented May 16, 2020

Uh oh!

patrykkopycinski commented May 17, 2020

Uh oh!

patrykkopycinski commented May 18, 2020

Uh oh!

patrykkopycinski commented May 19, 2020

Uh oh!

elasticmachine commented May 19, 2020

Uh oh!

patrykkopycinski commented Jun 21, 2020

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mshustov left a comment

Choose a reason for hiding this comment

Uh oh!

sebelga left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

mistic commented Oct 2, 2020

Uh oh!

spalger commented Oct 3, 2020

Uh oh!

kibanamachine commented Oct 3, 2020

Uh oh!

kibanamachine commented Oct 3, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

@kbn/ui-shared-deps asset size

async chunks size

distributable file count

page load bundle size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

patrykkopycinski commented May 14, 2020 •

edited

Loading

sebelga left a comment •

edited

Loading