Don't bootstrap core type emits#66377
Merged
rudolf merged 1 commit intoelastic:masterfrom May 15, 2020
Merged
Conversation
rudolf
added
chore
Team:Core
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
botelastic
bot
added
the
Team:Uptime - DEPRECATED
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
FrankHassanabad
approved these changes
May 13, 2020
Contributor
FrankHassanabad
left a comment
FrankHassanabad
left a comment
There was a problem hiding this comment.
SIEM side looks good, thank you for keeping all these solutions imports clean and thank you for all the work to improve the quality of everyone's code over time! Couldn't be happier with all gifts like the improved Types and changes to imports like this one.
lukeelmers
approved these changes
May 13, 2020
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
LGTM. Tested bootstrap & check_published_api_changes and all seems to work as expected.
joshdover
approved these changes
May 13, 2020
weltenwort
approved these changes
May 14, 2020
Member
weltenwort
left a comment
weltenwort
left a comment
There was a problem hiding this comment.
Seems to work for the infra plugin 👍 Thanks for investing the effort!
Contributor
Author
|
I'm going to merge without approval from elastic/uptime & elastic/endpoint-app-team since this is blocking #64395 and there is no risk of breaking any behaviour in these changes. |
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
May 15, 2020
rudolf
added a commit
that referenced
this pull request
May 15, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 15, 2020
…ent/add-support-in-url-for-hidden-toggle * 'master' of github.com:elastic/kibana: (34 commits) [SIEM][CASE] Fix bug when connector is deleted. (elastic#65876) [SIEM][CASE] Improve layout (elastic#66232) [Index Management] Support Hidden Indices (elastic#66422) Add Login Selector functional tests. (elastic#65705) Lens drilldowns (elastic#65675) [ML] Custom template for apiDoc markdown (elastic#66567) Don't bootstrap core type emits (elastic#66377) [Dashboard] Improve loading error handling (elastic#66372) [APM] Minor style fixes for the node strokes (elastic#66574) [Ingest Manager] Fix create data source from integration (elastic#66626) [Metrics UI] Fix default metric alert interval for new conditions (elastic#66610) [Metrics UI] Fix alignment and allow clearing metric value (elastic#66589) Don't return package name for non-package data streams (elastic#66606) [Ingest Manager] Consolidate routing and add breadcrumbs to all pages (elastic#66475) [Docs/Reporting] Have the docs about granular timeout match Cloud docs (elastic#66267) Don't automatically add license header to code inside plugins dir. (elastic#66601) [APM] Don't trigger map layout if no elements (elastic#66625) [Logs UI] Validate ML job setup time ranges (elastic#66426) Fix pagination bugs in CCR and Remote Clusters (elastic#65931) Add cloud icon for supported settings and embed single-sourced getting started (elastic#65610) ... # Conflicts: # x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js # x-pack/plugins/index_management/server/lib/fetch_indices.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Importing types from
kibana/serverorkibana/publicused to rely on.d.tsfiles intarget/types, so as part of bootstrap we generated these types so that IDE type checking won't fail.This is no longer necessary since
kibana.d.tsnow imports types from their source instead oftarget/typesso I've removed this expensive step from the bootstrap process.Checklist
Delete any items that are not applicable to this PR.
For maintainers