make sure remove sample data button is displayed and enabled before clicking#66322
Merged
LeeDr merged 1 commit intoelastic:masterfrom May 13, 2020
Merged
Conversation
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
LeeDr
added
release_note:skip
Author
|
Passed 50 times on flaky test runner. https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/449/ |
Dosant
approved these changes
May 13, 2020
Contributor
Dosant
left a comment
Dosant
left a comment
There was a problem hiding this comment.
Thanks for looking into it 🙏
hope this will indeed help
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
May 13, 2020
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
May 13, 2020
LeeDr
pushed a commit
that referenced
this pull request
May 14, 2020
LeeDr
pushed a commit
that referenced
this pull request
May 14, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt to fix flaky test
x-pack\test\functional\apps\dashboard\_async_dashboard.tsFixes: #65949
The logs when it fails doesn't show that it failed to find and click the remove button, but the screenshot looks like it wasn't clicked. My only thought is that it either is present but not displayed, or is present but not enabled, and we don't get an error logged when it clicks it (but nothing happens).
Checklist
Delete any items that are not applicable to this PR.