Skip to content

[Maps] handle case where fit to bounds does not match any documents #66307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2020
Merged

[Maps] handle case where fit to bounds does not match any documents #66307

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0cdd3f
[Maps] handle case where fit to bounds does not match any documents
nreese May 12, 2020
95f2229
review feedback
nreese May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions x-pack/plugins/maps/public/classes/sources/es_source/es_source.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,16 +163,12 @@ export class AbstractESSource extends AbstractVectorSource {
const esResp = await searchSource.fetch();
esBounds = _.get(esResp, 'aggregations.fitToBounds.bounds');
Copy link
Contributor

@thomasneirynck thomasneirynck May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than keep hiding the root-cause, could we remove use of lodash here?

 esBonds = aggregations.fitToBounds.bounds ? aggregations.fitToBounds.bounds : null;

or

if (!aggregations.fitToBounds.bounds) {
    return null;
} 
esBounds = aggregations.fitToBounds.bounds;

which helps clarity

} catch (error) {
esBounds = {
top_left: {
lat: 90,
lon: -180,
},
bottom_right: {
lat: -90,
lon: 180,
},
};
return null;
}

// aggregations.fitToBounds is empty object when there are no matching documents
if (!esBounds) {
return null;
}

const minLon = esBounds.top_left.lon;
Expand Down