[es6ify] re-apply automated transforms after ingest work#6623
Merged
Bargs merged 6 commits intoelastic:feature/ingestfrom Mar 24, 2016
Merged
[es6ify] re-apply automated transforms after ingest work#6623Bargs merged 6 commits intoelastic:feature/ingestfrom
Bargs merged 6 commits intoelastic:feature/ingestfrom
Conversation
spalger
force-pushed
the
es6ify/modules/ingest
branch
from
132580e to
8725bf4
Compare
spalger
force-pushed
the
es6ify/modules/ingest
branch
from
8725bf4 to
f4517fb
Compare
| @@ -1,12 +1,16 @@ | |||
| import PluginsKibanaSettingsSectionsIndicesRefreshKibanaIndexProvider from 'plugins/kibana/settings/sections/indices/_refresh_kibana_index'; | |||
Contributor
There was a problem hiding this comment.
I think the script got a bit carried away with the naming here ;)
Contributor
Author
There was a problem hiding this comment.
lol, yeah.... use relative paths!
Contributor
Author
There was a problem hiding this comment.
Would have been:
import refreshKibanaIndexProvider from '../_refresh_kibana_index'
Contributor
|
@spalger I submitted a pull against your branch to fix a few extra require statements hanging around spalger#15 Otherwise LGTM |
Fixing a few extra require statements hanging about in the ingest code
Contributor
|
LGTM - and thanks for fixing my sloppiness, I tried to make that PR in a hurry and totally missed the exports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #6614, but probably not everything