Skip to content

Comments

[SIEM][CASE] Fix configuration's page user experience #66029

Merged
cnasikas merged 16 commits intoelastic:masterfrom
cnasikas:fix_conf_page_ui
May 18, 2020
Merged

[SIEM][CASE] Fix configuration's page user experience #66029
cnasikas merged 16 commits intoelastic:masterfrom
cnasikas:fix_conf_page_ui

Conversation

@cnasikas
Copy link
Member

@cnasikas cnasikas commented May 11, 2020 •
edited
Loading

Summary

The PR fixes all issues of https://github.com/elastic/siem-team/issues/660

Save closure options

conf_1

Save connector

conf_2

Add connector

conf_3

conf_4

Single case: Change connector

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas self-assigned this May 11, 2020
@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.8.0 v7.9.0 v8.0.0 labels May 11, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented May 11, 2020

Pinging @elastic/siem (Team:SIEM)

@cnasikas cnasikas force-pushed the fix_conf_page_ui branch 2 times, most recently from 0b44cbc to c44fb7b Compare May 11, 2020 15:08
@cnasikas cnasikas marked this pull request as ready for review May 11, 2020 17:14
@cnasikas cnasikas requested review from a team as code owners May 11, 2020 17:14
@cnasikas cnasikas requested review from XavierM and stephmilovic May 11, 2020 17:14
@cnasikas cnasikas force-pushed the fix_conf_page_ui branch 4 times, most recently from d2badbf to 4810c9b Compare May 12, 2020 09:36
@stephmilovic
Copy link
Contributor

stephmilovic commented May 12, 2020

The new behavior should include:

  • start on configuration page
  • add a new connector from the dropdown
  • the connector should automatically be selected and saved in the dropdown

@stephmilovic
Copy link
Contributor

stephmilovic commented May 12, 2020

Confused whether this is a new bug or part of your other PR... this case has no connector, so connector_id: none:
Screen Shot 2020-05-12 at 8 16 07 AM
Yet on the case view:
Screen Shot 2020-05-12 at 8 15 34 AM

@cnasikas
Copy link
Member Author

cnasikas commented May 12, 2020 •
edited
Loading

Confused whether this is a new bug or part of your other PR... this case has no connector, so connector_id: none:
Screen Shot 2020-05-12 at 8 16 07 AM
Yet on the case view:
Screen Shot 2020-05-12 at 8 15 34 AM

Let's wait for #65876 to be merged and see if still persists.

@cnasikas cnasikas force-pushed the fix_conf_page_ui branch from 4810c9b to c522ded Compare May 15, 2020 11:44
@cnasikas cnasikas force-pushed the fix_conf_page_ui branch from 246881d to 22ba94d Compare May 16, 2020 15:11
@cnasikas
Copy link
Member Author

cnasikas commented May 17, 2020

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

cnasikas commented May 17, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented May 17, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

cnasikas commented May 18, 2020 •
edited
Loading

  • the connector should automatically be selected and saved in the dropdown

The id of the newly created connector is not being passed from the flyout to our callback. I opened an issue: #66908.

stephmilovic
stephmilovic approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review ✅ manual testing ✅

as discussed in slack, saving new connector as default automatically will need to wait for further support from the alerting team. Everything else is LGTM

@cnasikas cnasikas merged commit 304a4ac into elastic:master May 18, 2020
@cnasikas cnasikas deleted the fix_conf_page_ui branch May 18, 2020 22:07
@cnasikas cnasikas mentioned this pull request May 18, 2020
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request May 18, 2020
@cnasikas
[SIEM][CASE] Fix configuration's page user experience (elastic#66029)
ea6e746
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 19, 2020
@gmmorris
Merge branch 'master' into saved-objects/scoped-client-with-extra-types
cc95823 
* master: (24 commits)
  [APM] agent config 'profiling_inferred_spans_min_duration' default value is '0ms' but the min value in the field is '1ms' (elastic#66886)
  [Canvas] Fix flaky custom element functional tests (elastic#65908)
  Fix IE specific flexbox min-height issue (elastic#66555)
  [Discover] Unskip doc link functional test (elastic#66884)
  Index pattern management to Kibana platform (elastic#65026)
  Warning and link to support matrix for IE11 (elastic#66512)
  [Reporting] Consolidate Server Type Defs, move some out of Legacy (elastic#66144)
  [SIEM] [Maps] Fixes Network Map empty tooltip (elastic#66828)
  [Endpoint] Encode the index of the alert in the id response (elastic#66919)
  [services/testSubjects] reduce retry usage, add waitForEnabled (elastic#66538)
  [DOCS] Identifies cloud settings for APM (elastic#66935)
  [SIEM][CASE] Fix configuration's page user experience (elastic#66029)
  Resolver: Display node 75% view submenus (elastic#64121)
  [SIEM] Cases] Capture timeline click and open timeline in case view (elastic#66327)
  [APM] Lowercase agent names so icons work (elastic#66824)
  [dev/cli] add support for --no-cache (elastic#66837)
  [Ingest Manager] Better handling of package installation problems (elastic#66541)
  [ML] Enhances api docs for modules endpoints (elastic#66738)
  dont hide errors (elastic#66764)
  [RFC] Global search API (elastic#64284)
  ...
cnasikas added a commit that referenced this pull request May 19, 2020
@cnasikas
[7.x] [SIEM][CASE] Fix configuration's page user experience (#66029) (#…
6be9d4b 
…66936)
@cnasikas cnasikas mentioned this pull request May 19, 2020
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request May 19, 2020
@cnasikas
[SIEM][CASE] Fix configuration's page user experience (elastic#66029)
98d925d 
# Conflicts:
#	x-pack/plugins/siem/public/cases/components/callout/index.test.tsx
#	x-pack/plugins/siem/public/cases/components/configure_cases/connectors.test.tsx
#	x-pack/plugins/siem/public/cases/components/configure_cases/connectors.tsx
#	x-pack/plugins/siem/public/cases/components/configure_cases/connectors_dropdown.tsx
#	x-pack/plugins/siem/public/cases/components/configure_cases/index.test.tsx
#	x-pack/plugins/siem/public/cases/components/configure_cases/index.tsx
#	x-pack/plugins/siem/public/cases/components/edit_connector/index.test.tsx
#	x-pack/plugins/siem/public/cases/components/edit_connector/index.tsx
#	x-pack/plugins/siem/public/cases/components/use_push_to_service/index.tsx
cnasikas added a commit that referenced this pull request May 19, 2020
@cnasikas
[7.8] [SIEM][CASE] Fix configuration's page user experience (#66029) (#…
3bdbbc8 
…66972)
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@XavierM XavierM Awaiting requested review from XavierM

Assignees

@cnasikas cnasikas

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cnasikas @elasticmachine @stephmilovic @kibanamachine @MindyRS