Throw error in kbn-es when no reserved users found #65911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
v8.0.0
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced May 12, 2020
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
May 12, 2020
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
May 12, 2020
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
May 12, 2020
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
May 12, 2020
brianseeders
added a commit
that referenced
this pull request
May 12, 2020
brianseeders
added a commit
that referenced
this pull request
May 12, 2020
brianseeders
added a commit
that referenced
this pull request
May 12, 2020
brianseeders
added a commit
that referenced
this pull request
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some builds in CI have been failing randomly by hitting the 2h 15m timeout. It doesn't happen on master, but happens once or twice a day or so on
7.*.It turned out to be the upgrade_assistant tests. Sometimes, no reserved users exist after doing the initial data load. This would be 6.x data since it's for the upgrade assistant, which would explain why this issue is not affecting master (it has 7.x data for 8.0).
When no reserved users were found, kibana would never fully initialize, and a few errors would just repeat until the entire job timed out.
This PR immediately throws an error when this happens. This won't fix the main problem, but it will at least turn our timeouts into failures and give us some better data.
I was able to re-produce the problem and see this code working in the flaky test suite runner here: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/443/execution/node/411/log/