[SIEM] Eliminate Superfluous Untitled Timelines

x-pack/plugins/siem/common/constants.ts

@@ -91,6 +91,7 @@ export const DETECTION_ENGINE_RULES_STATUS_URL = `${DETECTION_ENGINE_RULES_URL}/
 export const DETECTION_ENGINE_PREPACKAGED_RULES_STATUS_URL = `${DETECTION_ENGINE_RULES_URL}/prepackaged/_status`;
 
 export const TIMELINE_URL = '/api/timeline';
+export const TIMELINE_DRAFT_URL = `${TIMELINE_URL}/_draft`;
 export const TIMELINE_EXPORT_URL = `${TIMELINE_URL}/_export`;
 export const TIMELINE_IMPORT_URL = `${TIMELINE_URL}/_import`;
 

x-pack/plugins/siem/common/types/timeline/index.ts

@@ -136,11 +136,13 @@ const SavedSortRuntimeType = runtimeTypes.partial({
 
 export enum TimelineType {
   default = 'default',
+  draft = 'draft',
   template = 'template',
 }
 
 export const TimelineTypeLiteralRt = runtimeTypes.union([
   runtimeTypes.literal(TimelineType.template),
+  runtimeTypes.literal(TimelineType.draft),
   runtimeTypes.literal(TimelineType.default),
 ]);
 

x-pack/plugins/siem/cypress/tasks/create_new_case.ts

@@ -32,6 +32,7 @@ export const createNewCase = (newCase: TestCase) => {
   cy.get(INSERT_TIMELINE_BTN).click({ force: true });
   cy.get(TIMELINE_SEARCHBOX).type(`${newCase.timeline.title}{enter}`);
   cy.get(TIMELINE).should('be.visible');
+  cy.wait(300);
   cy.get(TIMELINE)
     .eq(1)
     .click({ force: true });

x-pack/plugins/siem/public/common/components/top_n/index.test.tsx

@@ -26,6 +26,7 @@ import { Props } from './top_n';
 import { ACTIVE_TIMELINE_REDUX_ID, StatefulTopN } from '.';
 
 jest.mock('../../lib/kibana');
+jest.mock('../../../timelines/store/timeline/actions');
 
 const mockUiSettingsForFilterManager = createKibanaCoreStartMock().uiSettings;
 

x-pack/plugins/siem/public/common/mock/timeline_results.ts

@@ -2243,7 +2243,7 @@ export const defaultTimelineProps: CreateTimelineProps = {
     showRowRenderers: true,
     sort: { columnId: '@timestamp', sortDirection: Direction.desc },
     title: '',
-    timelineType: TimelineType.default,
+    timelineType: TimelineType.draft,
     templateTimelineVersion: null,
     templateTimelineId: null,
     version: null,

x-pack/plugins/siem/public/graphql/introspection.json

@@ -10377,6 +10377,7 @@
             "isDeprecated": false,
             "deprecationReason": null
           },
+          { "name": "draft", "description": "", "isDeprecated": false, "deprecationReason": null },
           {
             "name": "template",
             "description": "",

x-pack/plugins/siem/public/graphql/types.ts

@@ -342,6 +342,7 @@ export enum TlsFields {
 
 export enum TimelineType {
   default = 'default',
+  draft = 'draft',
   template = 'template',
 }
 

x-pack/plugins/siem/public/timelines/components/open_timeline/edit_timeline_batch_actions.tsx

@@ -20,7 +20,7 @@ const getExportedIds = (selectedTimelines: OpenTimelineResult[]) => {
   );
 };
 
-export const useEditTimelinBatchActions = ({
+export const useEditTimelineBatchActions = ({
   deleteTimelines,
   selectedItems,
   tableRef,

x-pack/plugins/siem/public/timelines/components/open_timeline/helpers.test.ts

@@ -11,14 +11,14 @@ import {
   mockTimelineResult,
   mockTimelineModel,
 } from '../../../common/mock/timeline_results';
-import { timelineDefaults } from '../../../timelines/store/timeline/defaults';
+import { timelineDefaults } from '../../store/timeline/defaults';
 import { setTimelineRangeDatePicker as dispatchSetTimelineRangeDatePicker } from '../../../common/store/inputs/actions';
 import {
   setKqlFilterQueryDraft as dispatchSetKqlFilterQueryDraft,
   applyKqlFilterQuery as dispatchApplyKqlFilterQuery,
   addTimeline as dispatchAddTimeline,
   addNote as dispatchAddGlobalTimelineNote,
-} from '../../../timelines/store/timeline/actions';
+} from '../../store/timeline/actions';
 import {
   addNotes as dispatchAddNotes,
   updateNote as dispatchUpdateNote,
@@ -39,7 +39,7 @@ import sinon from 'sinon';
 import { TimelineType } from '../../../../common/types/timeline';
 
 jest.mock('../../../common/store/inputs/actions');
-jest.mock('../../../timelines/store/timeline/actions');
+jest.mock('../../store/timeline/actions');
 jest.mock('../../../common/store/app/actions');
 jest.mock('uuid', () => {
   return {
@@ -300,7 +300,7 @@ describe('helpers', () => {
           sortDirection: 'desc',
         },
         title: '',
-        timelineType: TimelineType.default,
+        timelineType: TimelineType.draft,
         templateTimelineId: null,
         templateTimelineVersion: null,
         version: '1',
@@ -397,13 +397,14 @@ describe('helpers', () => {
           sortDirection: 'desc',
         },
         title: '',
-        timelineType: TimelineType.default,
+        timelineType: TimelineType.draft,
         templateTimelineId: null,
         templateTimelineVersion: null,
         version: '1',
         width: 1100,
       });
     });
+
     test('should merge columns when event.action is deleted without two extra column names of user.name', () => {
       const timeline = {
         savedObjectId: 'savedObject-1',
@@ -416,38 +417,80 @@ describe('helpers', () => {
         savedObjectId: 'savedObject-1',
         columns: [
           {
+            aggregatable: undefined,
+            category: undefined,
             columnHeaderType: 'not-filtered',
+            description: undefined,
+            example: undefined,
             id: '@timestamp',
+            placeholder: undefined,
+            type: undefined,
             width: 190,
           },
           {
+            aggregatable: undefined,
+            category: undefined,
             columnHeaderType: 'not-filtered',
+            description: undefined,
+            example: undefined,
             id: 'message',
+            placeholder: undefined,
+            type: undefined,
             width: 180,
           },
           {
+            aggregatable: undefined,
+            category: undefined,
             columnHeaderType: 'not-filtered',
+            description: undefined,
+            example: undefined,
             id: 'event.category',
+            placeholder: undefined,
+            type: undefined,
             width: 180,
           },
           {
+            aggregatable: undefined,
+            category: undefined,
             columnHeaderType: 'not-filtered',
+            description: undefined,
+            example: undefined,
             id: 'host.name',
+            placeholder: undefined,
+            type: undefined,
             width: 180,
           },
           {
+            aggregatable: undefined,
+            category: undefined,
             columnHeaderType: 'not-filtered',
+            description: undefined,
+            example: undefined,
             id: 'source.ip',
+            placeholder: undefined,
+            type: undefined,
             width: 180,
           },
           {
+            aggregatable: undefined,
+            category: undefined,
             columnHeaderType: 'not-filtered',
+            description: undefined,
+            example: undefined,
             id: 'destination.ip',
+            placeholder: undefined,
+            type: undefined,
             width: 180,
           },
           {
+            aggregatable: undefined,
+            category: undefined,
             columnHeaderType: 'not-filtered',
+            description: undefined,
+            example: undefined,
             id: 'user.name',
+            placeholder: undefined,
+            type: undefined,
             width: 180,
           },
         ],
@@ -474,7 +517,7 @@ describe('helpers', () => {
         },
         loadingEventIds: [],
         title: '',
-        timelineType: TimelineType.default,
+        timelineType: TimelineType.draft,
         templateTimelineId: null,
         templateTimelineVersion: null,
         noteIds: [],
@@ -642,7 +685,7 @@ describe('helpers', () => {
         },
         loadingEventIds: [],
         title: '',
-        timelineType: TimelineType.default,
+        timelineType: TimelineType.draft,
         templateTimelineId: null,
         templateTimelineVersion: null,
         noteIds: [],