Skip to content

[Maps] remove SLA percentage metric #65718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2020
Merged

[Maps] remove SLA percentage metric #65718

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44840a6
[Maps] remove SLA percentage metric
nreese May 7, 2020
e11c7c3
remove unused import
nreese May 7, 2020
4aa99f7
Merge branch 'master' into remove_sla_metric
elasticmachine May 7, 2020
0d418ef
Merge branch 'master' into remove_sla_metric
elasticmachine May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions x-pack/plugins/maps/public/layers/solution_layers/observability/create_layer_descriptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { i18n } from '@kbn/i18n';
import {
AggDescriptor,
ColorDynamicOptions,
LabelDynamicOptions,
LayerDescriptor,
SizeDynamicOptions,
StylePropertyField,
Expand Down Expand Up @@ -80,10 +79,6 @@ function createLayerLabel(
metricName = i18n.translate('xpack.maps.observability.durationMetricName', {
defaultMessage: 'Duration',
});
} else if (metric === OBSERVABILITY_METRIC_TYPE.SLA_PERCENTAGE) {
metricName = i18n.translate('xpack.maps.observability.slaPercentageMetricName', {
defaultMessage: '% Duration of SLA',
});
} else if (metric === OBSERVABILITY_METRIC_TYPE.COUNT) {
metricName = i18n.translate('xpack.maps.observability.countMetricName', {
defaultMessage: 'Total',
Expand All @@ -103,11 +98,6 @@ function createAggDescriptor(metric: OBSERVABILITY_METRIC_TYPE): AggDescriptor {
type: AGG_TYPE.AVG,
field: 'transaction.duration.us',
};
} else if (metric === OBSERVABILITY_METRIC_TYPE.SLA_PERCENTAGE) {
return {
type: AGG_TYPE.AVG,
field: 'duration_sla_pct',
};
} else if (metric === OBSERVABILITY_METRIC_TYPE.UNIQUE_COUNT) {
return {
type: AGG_TYPE.UNIQUE_COUNT,
Expand Down Expand Up @@ -251,16 +241,6 @@ export function createLayerDescriptor({
},
};

if (metric === OBSERVABILITY_METRIC_TYPE.SLA_PERCENTAGE) {
styleProperties[VECTOR_STYLES.LABEL_TEXT] = {
type: STYLE_TYPE.DYNAMIC,
options: {
...(defaultDynamicProperties[VECTOR_STYLES.LABEL_TEXT]!.options as LabelDynamicOptions),
field: metricStyleField,
},
};
}

return VectorLayer.createDescriptor({
label,
query: apmSourceQuery,
Expand Down
7 changes: 0 additions & 7 deletions x-pack/plugins/maps/public/layers/solution_layers/observability/metric_select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { OBSERVABILITY_LAYER_TYPE } from './layer_select';

export enum OBSERVABILITY_METRIC_TYPE {
TRANSACTION_DURATION = 'TRANSACTION_DURATION',
SLA_PERCENTAGE = 'SLA_PERCENTAGE',
COUNT = 'COUNT',
UNIQUE_COUNT = 'UNIQUE_COUNT',
}
Expand All @@ -23,12 +22,6 @@ const APM_RUM_PERFORMANCE_METRIC_OPTIONS = [
defaultMessage: 'Transaction duraction',
}),
},
{
value: OBSERVABILITY_METRIC_TYPE.SLA_PERCENTAGE,
text: i18n.translate('xpack.maps.observability.slaPercentageLabel', {
defaultMessage: 'SLA percentage',
}),
},
];

const APM_RUM_TRAFFIC_METRIC_OPTIONS = [
Expand Down