Skip to content

Conversation

@justinkambic
Copy link
Contributor

Summary

Resolves elastic/uptime#182.

Adds a functional test for the newly-added TLS alerting feature we will ship in 7.8.0.

Checklist

Delete any items that are not applicable to this PR.

@justinkambic justinkambic added test_ui_functional v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 labels May 5, 2020
@justinkambic justinkambic requested review from andrewvc and shahzad31 May 5, 2020 17:00
@justinkambic justinkambic self-assigned this May 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic requested review from andrewvc and shahzad31 and removed request for andrewvc and shahzad31 May 5, 2020 17:15
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

user doesn't have permission to update head repository

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@justinkambic justinkambic merged commit 6c13f7f into elastic:master May 6, 2020
justinkambic added a commit to justinkambic/kibana that referenced this pull request May 6, 2020
* Add alert option for flyout selection helper function.

* Add functional test for TLS alerts.
justinkambic added a commit to justinkambic/kibana that referenced this pull request May 6, 2020
* Add alert option for flyout selection helper function.

* Add functional test for TLS alerts.
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 7, 2020
* master: (42 commits)
  fix SavedObjectMigrationMap type (elastic#65569)
  [Uptime] Improve cert flaky test (elastic#65458)
  [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532)
  [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508)
  [APM] Remove link from active page in the breadcrumb (elastic#65473)
  [SIEM] Fixes test flakiness (elastic#65510)
  [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471)
  Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780)
  move core provier to NP. allows to run tests on every page (elastic#64929)
  Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201)
  [functional tests] add some missing awaits (elastic#65566)
  Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539)
  [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307)
  Migrate Coordinate Maps to NP (elastic#64668)
  Updating Canvas location in nav (elastic#65519)
  [SIEM][Lists] Fixes up contracts to work outside of requests
  [Lens] Remove "inside only" option for treemap labels (elastic#65363)
  [Uptime] Add TLS alert functional test (elastic#65303)
  Fix z-index of kbnLoadingIndicator (elastic#65521)
  Fixed indice assertion to loop through expected keys (elastic#64684)
  ...
justinkambic added a commit that referenced this pull request May 7, 2020
* Add alert option for flyout selection helper function.

* Add functional test for TLS alerts.

Co-authored-by: Elastic Machine <[email protected]>
justinkambic added a commit that referenced this pull request May 7, 2020
* Add alert option for flyout selection helper function.

* Add functional test for TLS alerts.

Co-authored-by: Elastic Machine <[email protected]>
@justinkambic
Copy link
Contributor Author

justinkambic commented May 7, 2020

@justinkambic justinkambic deleted the uptime_tls-alert-functional-test branch May 7, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test_ui_functional v7.8.0 v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Testing] Add functional test for TLS alert type

4 participants