[functional/page_objects] wait for infra ops page is loaded #65050
Conversation
dmlemeshko
added
release_note:skip
|
|
||
| return { | ||
| async goToTime(time: string) { | ||
| await testSubjects.missingOrFail('loadingMessage', { timeout: 20000 }); |
There was a problem hiding this comment.
I don't understand the reasoning for putting this here. Wouldn't it cause goToTime to fail if the loadingMessage is found?
In general, I think what ever action causes the loading should wait for the loadingMesage to clear (post action wait), instead of checking that it's not there before doing the next action (pre action check).
There was a problem hiding this comment.
@LeeDr I checked locally and that loading is happening after url navigation, I added await pageObjects.infraHome.waitForLoading(); in before method
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
LeeDr
left a comment
LeeDr
left a comment
There was a problem hiding this comment.
LGTM - Code review and Jenkins results. I didn't pull and run this PR locally.
…65050) * [functional/page_objects] wait for infra ops page is loaded * put waiting in PO method
4 participants
Summary
Closes #65016
Trying to fix flaky test by waiting for loading message to disappear.