Skip to content

Conversation

@dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Apr 28, 2020

Summary

Recently x-pack jest tests with --coverage flag started to take 4+ hours on CI.
After reading similar issues in jest repo, I added/modified collectCoverageFrom and coveragePathIgnorePatterns arrays to track only files we are interested in.

Looks like it solved the timeout issue:

Execute x-pack-intake - (2 hr 38 min in self) Jest Time: 9209.757s
Execute x-pack-intake - (1 hr 41 min in self) Jest Time: 5864.192s
Execute x-pack-intake - (2 hr 6 min in self) Jest Time: 7336.467s
Execute x-pack-intake - (1 hr 48 min in self) Jest Time: 6269.148s
Execute x-pack-intake - (1 hr 45 min in self) Jest Time: 6050.347s

Code coverage report is looking more full now as well:

Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I didn't test it locally.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Apr 29, 2020
@dmlemeshko dmlemeshko marked this pull request as ready for review April 29, 2020 16:46
@dmlemeshko dmlemeshko requested a review from a team as a code owner April 29, 2020 16:46
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko merged commit bac638a into elastic:master Apr 29, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 4, 2020
…bana into pipeline-editor-part-mvp-2

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (90 commits)
  remove unused import
  address review feedback
  [Ingest pipelines] Cleanup (elastic#64794)
  [Ingest] Edit datasource UI (elastic#64727)
  [Lens] Bind all time fields to the time picker (elastic#63874)
  [Lens] Use suggestion system in chart switcher for subtypes (elastic#64613)
  Improve alpha messaging (elastic#64692)
  [Ingest] Allow to enable monitoring of elastic agent (elastic#63598)
  [Metrics UI] Fix alerting when a filter query is present (elastic#64575)
  skip flaky suite (elastic#64812) (elastic#64723)
  [Maps] do not display EMS or kibana layer wizards when not configured (elastic#64554)
  [Reporting/Test] Convert functional test code to Typescript (elastic#64601)
  make inserting timestamp with navigate methods optional with default true (elastic#64655)
  [EPM] Update UI to handle package versions and updates (elastic#64689)
  Minimize dependencies required by our telemetry middleware (elastic#64665)
  [Telemetry] oss api tests (elastic#64602)
  [ML] Adding endpoint capability checks (elastic#64662)
  Update jest config for coverage (elastic#64648)
  [SIEM][NP] Fixes bug in ML signals promotion (elastic#64720)
  share single data plugin bundle (elastic#64549)
  ...
@dmlemeshko dmlemeshko deleted the update-jest-config-for-coverage branch January 31, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants