[Metrics UI] Fixes for editing alerts in alert management

[simianhacker]

Summary

This PR closes #64012 by setting the sourceId when it's not properly set and this also fixes the missing filter and group-by fields.

[phillipb]

LGTM

[phillipb]

Oops

[phillipb]

Can't clear the alert per selection on the edit screen.

[phillipb]

There's actually a bug in the underlying alert library that won't let us setAlertParams('groupBy', undefined), so this is causing a bug with clearing out the group by field in edit. We should update:

kibana/x-pack/plugins/infra/public/components/alerting/metrics/expression.tsx

Lines 151 to 152 in 0db04a7

	setAlertParams('groupBy', group || undefined);
	},

to be setAlertParams('groupBy', group || '');.

The bug in alerting is here:

kibana/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_reducer.ts

Lines 78 to 95 in daf6226

	case 'setAlertParams': {
	const { key, value } = payload;
	if (isEqual(alert.params[key], value)) {
	return state;
	} else {
	return {
	...state,
	alert: {
	...alert,
	params: {
	...alert.params,
	[key]: value,
	},
	},
	};
	}
	}
	case 'setAlertActionParams': {

[phillipb]

My bad, my comment wasn't clear enough.

[phillipb]

This call was actually not the problem. The one that needs to be updated is the onGroupByChange here:

kibana/x-pack/plugins/infra/public/components/alerting/metrics/expression.tsx

Lines 148 to 153 in 12aae67

	const onGroupByChange = useCallback(
	(group: string | null) => {
	setAlertParams('groupBy', group || undefined);
	},
	[setAlertParams]
	);

[phillipb]

LGTM

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: b82e9de

History

• 💚 Build #43636 succeeded b5ca754
• 💚 Build #43623 succeeded 0db04a7
• 💚 Build #43588 succeeded c3e2765

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream