-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Maps] initial location map settings #64336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b3cbe99
[Maps] initial location map settings
nreese 4cd59f9
fix tslint
nreese 1e63dc7
Merge branch 'master' of github.com:elastic/kibana into initial_location
nreese 29b8810
add button to set to current view
nreese f6b9b94
move button to bottom of form
nreese 1389d54
Merge branch 'master' into initial_location
elasticmachine e2dda1c
Merge branch 'master' into initial_location
elasticmachine eceff63
Merge branch 'master' into initial_location
elasticmachine 13af949
review feedback
nreese 44ba956
Merge branch 'master' into initial_location
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
x-pack/plugins/maps/public/connected_components/map/mb/get_initial_view.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import { INITIAL_LOCATION } from '../../../../common/constants'; | ||
| import { Goto, MapCenterAndZoom } from '../../../../common/descriptor_types'; | ||
| import { MapSettings } from '../../../reducers/map'; | ||
|
|
||
| export async function getInitialView( | ||
| goto: Goto | null, | ||
| settings: MapSettings | ||
| ): Promise<MapCenterAndZoom | null> { | ||
| if (settings.initialLocation === INITIAL_LOCATION.FIXED_LOCATION) { | ||
| return { | ||
| lat: settings.fixedLocation.lat, | ||
| lon: settings.fixedLocation.lon, | ||
| zoom: settings.fixedLocation.zoom, | ||
| }; | ||
| } | ||
|
|
||
| if (settings.initialLocation === INITIAL_LOCATION.BROWSER_LOCATION) { | ||
| return await new Promise((resolve, reject) => { | ||
| navigator.geolocation.getCurrentPosition( | ||
| // success callback | ||
| pos => { | ||
| resolve({ | ||
| lat: pos.coords.latitude, | ||
| lon: pos.coords.longitude, | ||
| zoom: settings.browserLocation.zoom, | ||
| }); | ||
| }, | ||
| // error callback | ||
| () => { | ||
| // eslint-disable-next-line no-console | ||
| console.warn('Unable to fetch browser location for initial map location'); | ||
| resolve(null); | ||
| } | ||
| ); | ||
| }); | ||
| } | ||
|
|
||
| return goto && goto.center ? goto.center : null; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
292 changes: 292 additions & 0 deletions
292
...blic/connected_components/map_settings_panel/__snapshots__/navigation_panel.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.