Async search observable can return a non-final response #64132

[lizozom]

Summary

Resolves #64132

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-browser compatibility, including a check against IE11

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[jimczi]

Looks good to me ;).

[streamich]

Code change LGTM.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 043e236

History

• 💔 Build #42380 failed c6688fb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[nreese]

@lizozom Can you provide a little more details about how this fixes the problem and what the problem is? I want to verify that consumers of SearchSource do not need to do anything different and this was a problem with the service.

[lizozom]

@nreese the problem here was not handling an error state returned by ES properly.
There was a case where ES doesn't return results, but we would assume that data should still be arriving. Hence we would poll until we tiemout.

[nreese]

So clients of SearchSource to not need to do anything special. Does SearchSource return partial results? How should clients handle that?