Skip to content

[APM]fixing custom link unit tests #64045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cauemarcondes merged 1 commit into from
Apr 22, 2020
Merged

[APM]fixing custom link unit tests #64045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...k/legacy/plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const data = [
];

describe('CustomLink', () => {
let callApmApiSpy: Function;
let callApmApiSpy: jasmine.Spy;
beforeAll(() => {
callApmApiSpy = spyOn(apmApi, 'callApmApi').and.returnValue({});
});
Expand Down Expand Up @@ -101,7 +101,7 @@ describe('CustomLink', () => {
]);
});

it('checks if create custom link button is available and working', () => {
it('checks if create custom link button is available and working', async () => {
const { queryByText, getByText } = render(
<LicenseContext.Provider value={goldLicense}>
<MockApmPluginContextWrapper>
Expand All @@ -113,6 +113,7 @@ describe('CustomLink', () => {
act(() => {
fireEvent.click(getByText('Create custom link'));
});
await wait(() => expect(callApmApiSpy).toHaveBeenCalled());
expect(queryByText('Create link')).toBeInTheDocument();
});
});
Expand Down Expand Up @@ -144,8 +145,10 @@ describe('CustomLink', () => {
act(() => {
fireEvent.click(component.getByText('Create custom link'));
});
await wait(() => component.queryByText('Create link'));
expect(component.queryByText('Create link')).toBeInTheDocument();
await wait(() =>
expect(component.queryByText('Create link')).toBeInTheDocument()
);
await wait(() => expect(callApmApiSpy).toHaveBeenCalled());
return component;
};

Expand Down
8 changes: 5 additions & 3 deletions ...pm/public/components/shared/TransactionActionMenu/__test__/TransactionActionMenu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

import React from 'react';
import { render, fireEvent, act } from '@testing-library/react';
import { render, fireEvent, act, wait } from '@testing-library/react';
import { TransactionActionMenu } from '../TransactionActionMenu';
import { Transaction } from '../../../../../../../../plugins/apm/typings/es_schemas/ui/transaction';
import * as Transactions from './mockData';
Expand Down Expand Up @@ -143,8 +143,9 @@ describe('TransactionActionMenu component', () => {
});

describe('Custom links', () => {
let callApmApiSpy: jasmine.Spy;
beforeAll(() => {
spyOn(apmApi, 'callApmApi').and.returnValue({});
callApmApiSpy = spyOn(apmApi, 'callApmApi').and.returnValue({});
});
afterAll(() => {
jest.resetAllMocks();
Expand Down Expand Up @@ -257,7 +258,7 @@ describe('TransactionActionMenu component', () => {
});
expectTextsInDocument(component, ['Custom Links']);
});
it('opens flyout with filters prefilled', () => {
it('opens flyout with filters prefilled', async () => {
const license = new License({
signature: 'test signature',
license: {
Expand Down Expand Up @@ -287,6 +288,7 @@ describe('TransactionActionMenu component', () => {
fireEvent.click(component.getByText('Create custom link'));
});
expectTextsInDocument(component, ['Create link']);
await wait(() => expect(callApmApiSpy).toHaveBeenCalled());
const getFilterKeyValue = (key: string) => {
return {
[(component.getAllByText(key)[0] as HTMLOptionElement)
Expand Down