[SIEM][CASE] Server common constants#63952
Merged
cnasikas merged 1 commit intoelastic:masterfrom Apr 21, 2020
Merged
Conversation
cnasikas
added
Team:SIEM
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
cnasikas
requested review from
andrew-goldstein,
angorayc,
patrykkopycinski and
stephmilovic
2 tasks
x-pack/plugins/case/server/routes/api/cases/comments/delete_comment.ts
Outdated
Show resolved
Hide resolved
stephmilovic
approved these changes
Apr 20, 2020
Contributor
stephmilovic
left a comment
stephmilovic
left a comment
There was a problem hiding this comment.
code review and passed manual testing locally via browser and sh scripts. just a few nits on naming, other than that LGTM
cnasikas
force-pushed
the
case_constants
branch
from
edbfad4 to
4dff15d
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Apr 21, 2020
cnasikas
added a commit
that referenced
this pull request
Apr 21, 2020
MindyRS
added
the
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create cases server common constants.
Checklist
Delete any items that are not applicable to this PR.
For maintainers