Skip to content

Code coverage: run more configs with functional tests#63680

Merged
dmlemeshko merged 3 commits intoelastic:masterfrom
dmlemeshko:collect-code-coverage-for-endpoint-tests
Apr 16, 2020
Merged

Code coverage: run more configs with functional tests#63680
dmlemeshko merged 3 commits intoelastic:masterfrom
dmlemeshko:collect-code-coverage-for-endpoint-tests

Conversation

@dmlemeshko
Copy link
Contributor

@dmlemeshko dmlemeshko commented Apr 16, 2020

Summary

This PR extends set of functional tests configs that we execute to collect code coverage:

  • Endpoint tests
  • Tests with ES SSL
  • Security tests with Basic license

Note: I think I didn't miss any other config with functional tests (running in Chrome browser), but if you think I did - please let me know.

Code coverage report is available here

Before:

coverage_1

After:

coverage_2

Endpoint plugin sources are listed in the report now
endpoint

@dmlemeshko dmlemeshko marked this pull request as ready for review April 16, 2020 12:23
@dmlemeshko dmlemeshko added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Apr 16, 2020
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmlemeshko ! Could you also add this one:

require.resolve('../test/plugin_functional/config.ts')

That has some tests for our Resolver embeddable used in the endpoint app.

cc: @oatkiller

@legrego
Copy link
Member

legrego commented Apr 16, 2020

Out of curiosity, how do we choose which test suites should be included for code coverage? I know we have the skipCoverage tag, but what determines why we tag a suite for exclusion?

Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dmlemeshko
Copy link
Contributor Author

dmlemeshko commented Apr 16, 2020

Out of curiosity, how do we choose which test suites should be included for code coverage? I know we have the skipCoverage tag, but what determines why we tag a suite for exclusion?

@legrego "Functional" code coverage is expected to run all the Kibana client-side tests, that can be executed in Chrome.
skipCoverage tag was added only to skip flaky/failing tests (yes, some tests fail only with source-mapped Kibana), just to have successful builds. I'm currently investigating failures and will create the issues.
The plan is not have it set anywhere :)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko merged commit 50228df into elastic:master Apr 16, 2020
@rylnd
Copy link
Contributor

rylnd commented Apr 17, 2020

@dmlemeshko did you want to backport this to 7.x? I'm backporting #63430 and have conflicts with jenkins_xpack.sh. Not a problem either way, just want to make sure I'm resolving correctly.

@dmlemeshko dmlemeshko deleted the collect-code-coverage-for-endpoint-tests branch January 31, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments