chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build by mistic · Pull Request #63486 · elastic/kibana

mistic · 2020-04-14T16:52:03Z

That solves a deprecation warning that was being logged during the canvas build: @babel/polyfill is deprecated. Please, use required parts of core-js and regenerator-runtime/runtime separately.

…runtime build

elasticmachine · 2020-04-14T16:52:06Z

Pinging @elastic/kibana-operations (Team:Operations)

mistic · 2020-04-15T15:04:38Z

@elasticmachine merge upstream

crob611 · 2020-04-17T14:50:30Z

@mistic When I run this, it give me an error Uncaught ReferenceError: regeneratorRuntime is not defined

If you want to test that any changes you make are working, you can extract the included file and can drop the built kbn_canvas.js in there and serve up that index.html. Should see an embedded workpad if everything is working properly.

canvas-workpad-embed.zip

mistic · 2020-04-17T17:35:37Z

@elasticmachine merge upstream

…reable-runtime-with-core-js

spalger

LGTM

spalger

Oops, I didn't see the comment from @crob611, maybe we should add regenerator-runtime/runtime?

spalger · 2020-04-17T18:35:28Z

There are a number of polyfills defined in @kbn/ui-shared-deps/polyfills that aren't here... But I also wonder if we should be embedding polyfills or supply a build of the sharable runtime with and without them...

mistic · 2020-04-17T20:05:08Z

@crob611 I forgot to add the regenerator-runtime/runtime previously, thanks for the example, now it's working. @spalger I believe we only need to include the core-js, the regenerator-runtime/runtime and the whatwg-fetch for now. Do you think we should add the same polyfill group we are using for ui-shared-deps?

x-pack/legacy/plugins/canvas/shareable_runtime/api/index.ts

spalger · 2020-04-17T23:13:22Z

Do you think we should add the same polyfill group we are using for ui-shared-deps?

I'm not sure, I think that's a design decision

mistic · 2020-04-20T12:45:21Z

@elasticmachine merge upstream

mistic · 2020-04-20T13:07:50Z

everything seems to be working well now

spalger

LGTM

mistic · 2020-04-22T13:10:59Z

@elasticmachine merge upstream

kibanamachine · 2020-04-22T14:59:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0bd48c6

History

💚 Build #41848 succeeded 6588db5
💚 Build #41689 succeeded dd25367
💚 Build #41643 succeeded 38fc0df
💚 Build #40990 succeeded f8141a5
💚 Build #40723 succeeded 837a8e2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…tic#63486) * chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build * chore(NA): include regenerator-runtime/runtime * chore(NA): change import order between runtime and core js Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…) (#64385) * chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build * chore(NA): include regenerator-runtime/runtime * chore(NA): change import order between runtime and core js Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…) (#64386) * chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build * chore(NA): include regenerator-runtime/runtime * chore(NA): change import order between runtime and core js Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (70 commits) KQL removes leading zero and breaks query (elastic#62748) [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193) [ML] Changes transforms wizard UI text (elastic#64150) [Alerting] change server log action type .log to .server-log in README (elastic#64124) [Metrics UI] Design Refresh: Inventory View, Episode 1 (elastic#64026) chore(NA): reduce siem bundle size using babel-plugin-transfor… (elastic#63269) chore(NA): use core-js instead of babel-polyfill on canvas sha… (elastic#63486) skip flaky suite (elastic#61173) skip flaky suite (elastic#62497) Renamed ilm policy for event log so it is not prefixed with dot (elastic#64262) [eslint] no_restricted_paths config cleanup (elastic#63741) Add Oil Rig Icon from @elastic/maki (elastic#64364) [Maps] Migrate Maps embeddables to NP (elastic#63976) [Ingest] Data streams list page (elastic#64134) chore(NA): add file-loader into jest moduleNameMapper (elastic#64330) [DOCS] Added images to automating report generation (elastic#64333) [SIEM][CASE] Api Integration Tests: Configuration (elastic#63948) Expose ability to check if API Keys are enabled (elastic#63454) [DOCS] Fixes formatting in alerting doc (elastic#64338) [data.search.aggs]: Create agg types function for terms agg. (elastic#63541) ...

…a… (#63486) (#64386)" This reverts commit 0338f8e.

…tic#63486) * chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build * chore(NA): include regenerator-runtime/runtime * chore(NA): change import order between runtime and core js Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

chore(NA): use core-js instead of babel-polyfill on canvas shareable …

837a8e2

…runtime build

mistic added chore Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.7.1 labels Apr 14, 2020

mistic requested a review from a team as a code owner April 14, 2020 16:52

Merge branch 'master' into update-canvas-shareable-runtime-with-core-js

f8141a5

elasticmachine and others added 2 commits April 17, 2020 13:35

Merge branch 'master' into update-canvas-shareable-runtime-with-core-js

23eae12

Merge remote-tracking branch 'upstream/master' into update-canvas-sha…

38fc0df

…reable-runtime-with-core-js

spalger approved these changes Apr 17, 2020

View reviewed changes

spalger suggested changes Apr 17, 2020

View reviewed changes

chore(NA): include regenerator-runtime/runtime

dd25367

spalger reviewed Apr 17, 2020

View reviewed changes

x-pack/legacy/plugins/canvas/shareable_runtime/api/index.ts Show resolved Hide resolved

elasticmachine and others added 2 commits April 20, 2020 08:45

Merge branch 'master' into update-canvas-shareable-runtime-with-core-js

12efac3

chore(NA): change import order between runtime and core js

6588db5

spalger approved these changes Apr 20, 2020

View reviewed changes

Merge branch 'master' into update-canvas-shareable-runtime-with-core-js

0bd48c6

spalger merged commit 34de1ae into elastic:master Apr 24, 2020

spalger mentioned this pull request Apr 24, 2020

[7.x] chore(NA): use core-js instead of babel-polyfill on canvas sha… (#63486) #64385

Merged

spalger mentioned this pull request Apr 24, 2020

[7.7] chore(NA): use core-js instead of babel-polyfill on canvas sha… (#63486) #64386

Merged

spalger added a commit that referenced this pull request Apr 29, 2020

Revert "chore(NA): use core-js instead of babel-polyfill on canvas sh…

527ea3f

…a… (#63486) (#64386)" This reverts commit 0338f8e.

spalger mentioned this pull request Apr 29, 2020

[7.7] chore(NA): use core-js instead of babel-polyfill on canvas sha… (#63486) #64732

Closed

Conversation

mistic commented Apr 14, 2020

Uh oh!

elasticmachine commented Apr 14, 2020

Uh oh!

mistic commented Apr 15, 2020

Uh oh!

crob611 commented Apr 17, 2020

Uh oh!

mistic commented Apr 17, 2020

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

spalger left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spalger commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mistic commented Apr 17, 2020

Uh oh!

Uh oh!

spalger commented Apr 17, 2020

Uh oh!

mistic commented Apr 20, 2020

Uh oh!

mistic commented Apr 20, 2020

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

mistic commented Apr 22, 2020

Uh oh!

kibanamachine commented Apr 22, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

spalger left a comment •

edited

Loading

spalger commented Apr 17, 2020 •

edited

Loading