Skip to content

[7.x] Adjust API authorization logging (#63350) #63456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
legrego merged 3 commits into from
Apr 14, 2020
Merged

[7.x] Adjust API authorization logging (#63350) #63456

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
694b1ab
Adjust API authorization logging (#63350)
legrego Apr 14, 2020
faf0afc
Merge branch '7.x' into backport/7.x/pr-63350
elasticmachine Apr 14, 2020
ff40420
Merge branch '7.x' into backport/7.x/pr-63350
elasticmachine Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions x-pack/plugins/security/server/authorization/api_authorization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export function initAPIAuthorization(

// if there are no tags starting with "access:", just continue
if (actionTags.length === 0) {
logger.debug('API endpoint is not marked with "access:" tags, skipping.');
return toolkit.next();
}

Expand All @@ -34,11 +33,11 @@ export function initAPIAuthorization(

// we've actually authorized the request
if (checkPrivilegesResponse.hasAllRequested) {
logger.debug(`authorized for "${request.url.path}"`);
logger.debug(`User authorized for "${request.url.path}"`);
return toolkit.next();
}

logger.debug(`not authorized for "${request.url.path}"`);
logger.warn(`User not authorized for "${request.url.path}": responding with 404`);
return response.notFound();
});
}