Skip to content

[7.x] [APM] Service map - fixes layout issues for maps with no rum services (#62887)#63002

Merged
ogupte merged 1 commit intoelastic:7.xfrom
ogupte:backport/7.x/pr-62887
Apr 9, 2020
Merged

[7.x] [APM] Service map - fixes layout issues for maps with no rum services (#62887)#63002
ogupte merged 1 commit intoelastic:7.xfrom
ogupte:backport/7.x/pr-62887

Conversation

@ogupte
Copy link
Contributor

@ogupte ogupte commented Apr 8, 2020

Backports the following commits to 7.x:

…elastic#62887)

* Closes elastic#62878 in Service Maps by improving the selection algorithm for root nodes

* Fixes some latent centering issues when navigating in the service map.

* Removes unused imports

* Added layoutstopDelayTimeout to cleanup step
@ogupte ogupte added the backport This PR is a backport of another PR label Apr 8, 2020
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/custom_elements·ts.Canvas app custom elements adds the custom element to the workpad when prompted

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:01:24]         └-: Canvas app
[00:01:24]           └-> "before all" hook
[00:02:14]           └-: custom elements
[00:02:14]             └-> "before all" hook
[00:02:14]             └-> "before all" hook
[00:02:14]               │ info [logstash_functional] Loading "mappings.json"
[00:02:14]               │ info [logstash_functional] Loading "data.json.gz"
[00:02:14]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:02:14]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:02:14]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:02:15]               │ info [canvas/default] Loading "mappings.json"
[00:02:15]               │ info [canvas/default] Loading "data.json.gz"
[00:02:15]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1586370588355480985] [.kibana_1/f-8p8NcNT1imLMEDOMgPTw] deleting index
[00:02:15]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1586370588355480985] [.kibana_2/sJSj-DEFSOS1QsxXDkK4HQ] deleting index
[00:02:15]               │ info [canvas/default] Deleted existing index [".kibana_2",".kibana_1"]
[00:02:15]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1586370588355480985] applying create index request using v1 templates []
[00:02:15]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1586370588355480985] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:02:16]               │ info [canvas/default] Created index ".kibana_1"
[00:02:16]               │ debg [canvas/default] ".kibana_1" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:02:16]               │ info [canvas/default] Indexed 3 docs into ".kibana_1"
[00:02:16]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xl-1586370588355480985] [.kibana_1/SIvleGUnQ-GXh9VzDdursg] update_mapping [_doc]
[00:02:16]               │ debg Migrating saved objects
[00:02:17]               │ proc [kibana]   log   [19:18:26.336] [info][savedobjects-service] Creating index .kibana_2.
[00:02:17]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1586370588355480985] applying create index request using v1 templates []
[00:02:17]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1586370588355480985] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:02:17]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1586370588355480985] updating number_of_replicas to [0] for indices [.kibana_2]
[00:02:17]               │ proc [kibana]   log   [19:18:26.452] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:02:17]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xl-1586370588355480985] [.kibana_2/VVOiSZ1ETve3k_HLzpA85A] update_mapping [_doc]
[00:02:17]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xl-1586370588355480985] [.kibana_2/VVOiSZ1ETve3k_HLzpA85A] update_mapping [_doc]
[00:02:17]               │ proc [kibana]   log   [19:18:26.586] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:02:17]               │ proc [kibana]   log   [19:18:26.665] [info][savedobjects-service] Finished in 331ms.
[00:02:17]               │ debg navigating to canvas url: http://localhost:6121/app/canvas#/
[00:02:17]               │ debg navigate to: http://localhost:6121/app/canvas#/
[00:02:17]               │ debg browser[INFO] http://localhost:6121/app/canvas?_t=1586373506671#/ 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:17]               │
[00:02:17]               │ debg browser[INFO] http://localhost:6121/bundles/app/canvas/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:17]               │ debg ... sleep(700) start
[00:02:18]               │ debg ... sleep(700) end
[00:02:18]               │ debg returned from get, calling refresh
[00:02:19]               │ debg browser[INFO] http://localhost:6121/app/canvas?_t=1586373506671#/ 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:19]               │
[00:02:19]               │ debg browser[INFO] http://localhost:6121/bundles/app/canvas/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:19]               │ debg currentUrl = http://localhost:6121/app/canvas#/
[00:02:19]               │          appUrl = http://localhost:6121/app/canvas#/
[00:02:19]               │ debg TestSubjects.find(kibanaChrome)
[00:02:19]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:22]               │ debg browser[INFO] http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-04-08T19:18:31Z
[00:02:22]               │        Adding connection to http://localhost:6121/elasticsearch
[00:02:22]               │
[00:02:22]               │      "
[00:02:23]               │ debg ... sleep(501) start
[00:02:23]               │ debg ... sleep(501) end
[00:02:23]               │ debg in navigateTo url = http://localhost:6121/app/canvas#/
[00:02:23]               │ debg TestSubjects.exists(statusPageContainer)
[00:02:23]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:02:26]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:02:26]               │ debg navigating to canvas url: http://localhost:6121/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:26]               │ debg navigate to: http://localhost:6121/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:26]               │ debg browser[INFO] http://localhost:6121/app/canvas?_t=1586373515842#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:26]               │
[00:02:26]               │ debg browser[INFO] http://localhost:6121/bundles/app/canvas/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:26]               │ debg ... sleep(700) start
[00:02:27]               │ debg ... sleep(700) end
[00:02:27]               │ debg returned from get, calling refresh
[00:02:28]               │ debg browser[INFO] http://localhost:6121/app/canvas?_t=1586373515842#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:28]               │
[00:02:28]               │ debg browser[INFO] http://localhost:6121/bundles/app/canvas/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:28]               │ debg currentUrl = http://localhost:6121/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:28]               │          appUrl = http://localhost:6121/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:28]               │ debg TestSubjects.find(kibanaChrome)
[00:02:28]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:32]               │ debg browser[INFO] http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-04-08T19:18:40Z
[00:02:32]               │        Adding connection to http://localhost:6121/elasticsearch
[00:02:32]               │
[00:02:32]               │      "
[00:02:32]               │ debg ... sleep(501) start
[00:02:32]               │ debg ... sleep(501) end
[00:02:32]               │ debg in navigateTo url = http://localhost:6121/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:32]               │ debg TestSubjects.exists(statusPageContainer)
[00:02:32]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:02:35]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:02:36]             └-> creates a custom element from an element when prompted
[00:02:36]               └-> "before each" hook: global before each
[00:02:36]               │ debg TestSubjects.click(canvasWorkpadPage > canvasWorkpadPageElementContent)
[00:02:36]               │ debg Find.clickByCssSelector('[data-test-subj="canvasWorkpadPage"] [data-test-subj="canvasWorkpadPageElementContent"]') with timeout=20000
[00:02:36]               │ debg Find.findByCssSelector('[data-test-subj="canvasWorkpadPage"] [data-test-subj="canvasWorkpadPageElementContent"]') with timeout=20000
[00:02:36]               │ debg Find.clickByCssSelector('[aria-label="Save as new element"]') with timeout=20000
[00:02:36]               │ debg Find.findByCssSelector('[aria-label="Save as new element"]') with timeout=20000
[00:02:36]               │ debg TestSubjects.setValue(canvasCustomElementForm-name, My New Element)
[00:02:36]               │ debg TestSubjects.click(canvasCustomElementForm-name)
[00:02:36]               │ debg Find.clickByCssSelector('[data-test-subj="canvasCustomElementForm-name"]') with timeout=10000
[00:02:36]               │ debg Find.findByCssSelector('[data-test-subj="canvasCustomElementForm-name"]') with timeout=10000
[00:02:37]               │ debg TestSubjects.setValue(canvasCustomElementForm-description, An excellent new element)
[00:02:37]               │ debg TestSubjects.click(canvasCustomElementForm-description)
[00:02:37]               │ debg Find.clickByCssSelector('[data-test-subj="canvasCustomElementForm-description"]') with timeout=10000
[00:02:37]               │ debg Find.findByCssSelector('[data-test-subj="canvasCustomElementForm-description"]') with timeout=10000
[00:02:37]               │ debg TestSubjects.click(canvasCustomElementForm-submit)
[00:02:37]               │ debg Find.clickByCssSelector('[data-test-subj="canvasCustomElementForm-submit"]') with timeout=10000
[00:02:37]               │ debg Find.findByCssSelector('[data-test-subj="canvasCustomElementForm-submit"]') with timeout=10000
[00:02:37]               │ debg TestSubjects.exists(canvasCustomElementCreate-success)
[00:02:37]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="canvasCustomElementCreate-success"]') with timeout=30000
[00:02:38]               └- ✓ pass  (2.2s) "Canvas app custom elements creates a custom element from an element when prompted"
[00:02:38]             └-> adds the custom element to the workpad when prompted
[00:02:38]               └-> "before each" hook: global before each
[00:02:38]               │ debg TestSubjects.click(add-element-button)
[00:02:38]               │ debg Find.clickByCssSelector('[data-test-subj="add-element-button"]') with timeout=10000
[00:02:38]               │ debg Find.findByCssSelector('[data-test-subj="add-element-button"]') with timeout=10000
[00:02:38]               │ debg Find.clickByCssSelector('#customElements') with timeout=20000
[00:02:38]               │ debg Find.findByCssSelector('#customElements') with timeout=20000
[00:02:38]               │ debg Find.findByCssSelector('[aria-labelledby="customElements"] .canvasElementCard__wrapper') with timeout=10000
[00:02:48]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/Canvas app custom elements adds the custom element to the workpad when prompted.png"
[00:02:48]               │ info Current URL is: http://localhost:6121/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:48]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/Canvas app custom elements adds the custom element to the workpad when prompted.html
[00:02:48]               └- ✖ fail: "Canvas app custom elements adds the custom element to the workpad when prompted"
[00:02:48]               │

Stack Trace

{ TimeoutError: Waiting for element to be located By(css selector, [aria-labelledby="customElements"] .canvasElementCard__wrapper)
Wait timed out after 10022ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:841:17
    at process._tickCallback (internal/process/next_tick.js:68:7) name: 'TimeoutError', remoteStacktrace: '' }

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ogupte ogupte merged commit 0dd2858 into elastic:7.x Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants