[Ingest] Update Create datasource UI to fit in one page#62858
[Ingest] Update Create datasource UI to fit in one page#62858nchaulet merged 13 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
081d59f to
d22ea9f
Compare
...ons/ingest_manager/sections/agent_config/create_datasource_page/components/confirm_modal.tsx
Outdated
Show resolved
Hide resolved
...er/public/applications/ingest_manager/sections/agent_config/create_datasource_page/index.tsx
Outdated
Show resolved
Hide resolved
|
Going to do a full review later but just an FYI that @hbharding updated the designs a bit so that the bottom bar does not cover the side nav (for both expanded and collapsed side nav): Here's an example PR that accounts for the side nav with a bottom bar (thanks @cjcenizal!): #60833 |
|
Looks great thanks @nchaulet! You probably noticed the "disabled" steps 2+3 don't exist in EUI the way i showed them in my designs. I spoke with the EUI team and I'll be working on a small PR to add this, but we'll have to wait until the next release |
|
@hbharding Yes currently we can only disable the step badge |
…t-new-create-datasource-steps
…t-new-create-datasource-steps
jen-huang
left a comment
There was a problem hiding this comment.
Visual review:
- The left and right margins around the content is bit weird. I think we probably need to reduce the max width of the content (in both the grey header and page content). @hbharding do you have a recommendation for the max width?
- The header content that shows "Integration" and/or "Configuration" can be removed as per designs; the page title also needs to be changed. Design:
- After de-selecting the integration (or configuration, if coming from EPM), the save button should be disabled again. Right now it stays enabled:
...ons/ingest_manager/sections/agent_config/create_datasource_page/components/confirm_modal.tsx
Outdated
Show resolved
Hide resolved
...ons/ingest_manager/sections/agent_config/create_datasource_page/components/confirm_modal.tsx
Outdated
Show resolved
Hide resolved
...plications/ingest_manager/sections/agent_config/create_datasource_page/components/layout.tsx
Outdated
Show resolved
Hide resolved
...plications/ingest_manager/sections/agent_config/create_datasource_page/components/layout.tsx
Outdated
Show resolved
Hide resolved
|
One future enhancement that might be nice would be to scroll down to Step 2 after the user makes a selection in Step 1. Step 1 takes most of my viewport when I'm on laptop. Not required for this PR, but @hbharding how do you feel about automatic scroll? |
@jen-huang @hbharding what do you think of keeping it? I think it help keeping the context from where you come from |
|
Also noticed 1 small thing about the layout. My designs use a tighter wrapper for the header and the body area. The design is 770px... or 8 / 12 columns... or 66% the width of the page wrapper, which is 1168px (1200px is you include left/right margin) :) I'll leave it up to you to decide how we do this. |
|
@elasticmachine merge upstream |
jen-huang
left a comment
There was a problem hiding this comment.
A few copy suggestions but otherwise LGTM! Thanks for making the changes.
...er/public/applications/ingest_manager/sections/agent_config/create_datasource_page/index.tsx
Outdated
Show resolved
Hide resolved
...plications/ingest_manager/sections/agent_config/create_datasource_page/components/layout.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
…om:nchaulet/kibana into feature-ingest-new-create-datasource-steps
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |





Description
Resolves #60696
Convert the existing create datasource pages into one page.
Change:
Screenshots
Updated header
