-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Maps] create NOT EXISTS filter for tooltip property with no value #62849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import { IFieldType, IndexPattern } from '../../../../../../src/plugins/data/public'; | ||
| import { ESTooltipProperty } from './es_tooltip_property'; | ||
| import { TooltipProperty } from './tooltip_property'; | ||
| import { AbstractField } from '../fields/field'; | ||
| import { FIELD_ORIGIN } from '../../../common/constants'; | ||
|
|
||
| class MockField extends AbstractField {} | ||
|
|
||
| const indexPatternField = { | ||
| name: 'machine.os', | ||
| type: 'string', | ||
| esTypes: ['text'], | ||
| count: 0, | ||
| scripted: false, | ||
| searchable: true, | ||
| aggregatable: true, | ||
| readFromDocValues: false, | ||
| } as IFieldType; | ||
|
|
||
| const featurePropertyField = new MockField({ | ||
| fieldName: 'machine.os', | ||
| origin: FIELD_ORIGIN.SOURCE, | ||
| }); | ||
|
|
||
| const indexPattern = { | ||
| id: 'indexPatternId', | ||
| fields: { | ||
| getByName: (name: string): IFieldType | null => { | ||
| return name === 'machine.os' ? indexPatternField : null; | ||
| }, | ||
| }, | ||
| title: 'my index pattern', | ||
| } as IndexPattern; | ||
|
|
||
| describe('getESFilters', () => { | ||
| test('Should return empty array when field does not exist in index pattern', async () => { | ||
| const notFoundFeaturePropertyField = new MockField({ | ||
| fieldName: 'field name that is not in index pattern', | ||
| origin: FIELD_ORIGIN.SOURCE, | ||
| }); | ||
| const esTooltipProperty = new ESTooltipProperty( | ||
| new TooltipProperty( | ||
| notFoundFeaturePropertyField.getName(), | ||
| await notFoundFeaturePropertyField.getLabel(), | ||
| 'my value' | ||
| ), | ||
| indexPattern, | ||
| notFoundFeaturePropertyField | ||
| ); | ||
| expect(await esTooltipProperty.getESFilters()).toEqual([]); | ||
| }); | ||
|
|
||
| test('Should return phrase filter when field value is provided', async () => { | ||
| const esTooltipProperty = new ESTooltipProperty( | ||
| new TooltipProperty( | ||
| featurePropertyField.getName(), | ||
| await featurePropertyField.getLabel(), | ||
| 'my value' | ||
| ), | ||
| indexPattern, | ||
| featurePropertyField | ||
| ); | ||
| expect(await esTooltipProperty.getESFilters()).toEqual([ | ||
| { | ||
| meta: { | ||
| index: 'indexPatternId', | ||
| }, | ||
| query: { | ||
| match_phrase: { | ||
| ['machine.os']: 'my value', | ||
| }, | ||
| }, | ||
| }, | ||
| ]); | ||
| }); | ||
|
|
||
| test('Should return NOT exists filter for null values', async () => { | ||
| const esTooltipProperty = new ESTooltipProperty( | ||
| new TooltipProperty( | ||
| featurePropertyField.getName(), | ||
| await featurePropertyField.getLabel(), | ||
| undefined | ||
| ), | ||
| indexPattern, | ||
| featurePropertyField | ||
| ); | ||
| expect(await esTooltipProperty.getESFilters()).toEqual([ | ||
| { | ||
| meta: { | ||
| index: 'indexPatternId', | ||
| negate: true, | ||
| }, | ||
| exists: { | ||
| field: 'machine.os', | ||
| }, | ||
| }, | ||
| ]); | ||
| }); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,8 +7,12 @@ | |
| import _ from 'lodash'; | ||
| import { ITooltipProperty } from './tooltip_property'; | ||
| import { IField } from '../fields/field'; | ||
| import { esFilters, IFieldType, IndexPattern } from '../../../../../../src/plugins/data/public'; | ||
| import { PhraseFilter } from '../../../../../../src/plugins/data/public'; | ||
| import { | ||
| esFilters, | ||
| Filter, | ||
| IFieldType, | ||
| IndexPattern, | ||
| } from '../../../../../../src/plugins/data/public'; | ||
|
|
||
| export class ESTooltipProperty implements ITooltipProperty { | ||
| private readonly _tooltipProperty: ITooltipProperty; | ||
|
|
@@ -64,12 +68,19 @@ export class ESTooltipProperty implements ITooltipProperty { | |
| ); | ||
| } | ||
|
|
||
| async getESFilters(): Promise<PhraseFilter[]> { | ||
| async getESFilters(): Promise<Filter[]> { | ||
| const indexPatternField = this._getIndexPatternField(); | ||
| if (!indexPatternField) { | ||
| return []; | ||
| } | ||
|
|
||
| return [esFilters.buildPhraseFilter(indexPatternField, this.getRawValue(), this._indexPattern)]; | ||
| const value = this.getRawValue(); | ||
| if (value == null) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would like to leave the check as |
||
| const existsFilter = esFilters.buildExistsFilter(indexPatternField, this._indexPattern); | ||
| existsFilter.meta.negate = true; | ||
| return [existsFilter]; | ||
| } else { | ||
| return [esFilters.buildPhraseFilter(indexPatternField, value, this._indexPattern)]; | ||
| } | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.